Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Net6 in the conditional to take the reference System.Drawing.Co… #484

Closed
wants to merge 1 commit into from

Conversation

luisfbn
Copy link

@luisfbn luisfbn commented Jan 25, 2024

Added Net6 in the conditional to take the reference System.Drawing.Common.
Net35 was removed due to System.Drawing.Bitmap type does not exist on it.

Summary

This PR fixes/implements the following bugs/features:

What existing problem does the pull request solve?**

Creating a .Net 6 Project and try to use QRCode type on it. Visual Studio can't compile due to: The type or namespace name 'QRCode' does not exist in the namespace 'QRCoder'

Closing issues

closes #382

…mmon. Net35 was removed due to System.Drawing.Bitmap type does not exist on it;
@Briaoeuidhtns
Copy link

it isn't available on all net6.0 targets, only the windows one. https://learn.microsoft.com/en-us/dotnet/core/compatibility/core-libraries/6.0/system-drawing-common-windows-only

@codebude
Copy link
Owner

codebude commented Apr 2, 2024

Hi @luisfbn ,

as @Briaoeuidhtns says - System.Drawing.Common is only available on Windows platforms. That's why I added the restrictions. I don't get how your changes can/shall work. Can you explain it to me? (My understanding is, that this shouldn't be possible.)

@luisfbn
Copy link
Author

luisfbn commented Apr 2, 2024

Hi @codebude
Yes, sorry for the confusion, @Briaoeuidhtns is right.
I only tested on Windows.

@luisfbn luisfbn closed this Apr 2, 2024
@luisfbn luisfbn deleted the FixIssue382 branch April 2, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants