Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added HMSPicker negative duration option #278

Closed
wants to merge 1 commit into from

Conversation

paxxux
Copy link
Contributor

@paxxux paxxux commented May 6, 2016

Hi,

as requested in #274 I created a pull request. (I am fairly new to git, and do not have time right now to get into it. Hope it works for you.)

Greetings,
paxxux

@paxxux paxxux changed the title Added negative duration option Added HMSPicker negative duration option May 6, 2016
@fchauveau
Copy link
Member

Thanks @paxxux
I'll test it this weekend

@fchauveau fchauveau self-assigned this May 6, 2016
@paxxux
Copy link
Contributor Author

paxxux commented May 7, 2016

great

@fchauveau
Copy link
Member

@paxxux I didnt forget you. I tested it and it works correctly, I'll merge it soon

@paxxux
Copy link
Contributor Author

paxxux commented May 10, 2016

Thank you very much! Could you test/merge #279 as well please :-)?

Greetings,
paxxux

@fchauveau
Copy link
Member

Can you update PR to make it point to branch HMSminus : https://github.com/code-troopers/android-betterpickers/tree/HMSmius
So I will be able do add few things before merging.

Thx

@fchauveau fchauveau mentioned this pull request May 11, 2016
@fchauveau
Copy link
Member

will be merged via #281

@fchauveau fchauveau closed this May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants