Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apartment sink model is inaccurate in URDF #100

Open
daniel86 opened this issue Sep 27, 2022 · 1 comment
Open

Apartment sink model is inaccurate in URDF #100

daniel86 opened this issue Sep 27, 2022 · 1 comment
Labels
enhancement

Comments

@daniel86
Copy link
Contributor

daniel86 commented Sep 27, 2022 •
edited

The sink components are not appropriately modeled:

  • tap has as parent side_B, it should be sink
  • there is a rotational joint between tap and sink (the tap can be rotated)
  • the tap has a handle component, there is a joint between handle and tap
  • the parent of sink is side_B. should it be island_countertop instead?
@daniel86 daniel86 changed the title Sink model is inaccurate in URDF Apartment sink model is inaccurate in URDF Sep 27, 2022
HoangGiang93 added a commit that referenced this issue Oct 13, 2022
@HoangGiang93
Fix issues #100
b44b6e9
@HoangGiang93
Copy link
Contributor

FixIssues100-2022-10-13_13.14.31.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daniel86 @HoangGiang93