Changes to make the PDF Fill #143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deletion of Leading and Trailing spaces and Filling of form questions 6 and 7.
Using String.includes for checking if checkbox options are selected. This should be checked on other browsers.
Using String.includes for checking if checkbox options are selected. This should be checked on other browsers.
using === for radio options to only fill if one option is selected and String.includes for testing if checkbox is selected.
ran lint fix and understood changes. Fixed != to !==. Additionally, there remain several formatting issues. Including leading and trailiing spaces, and getting multiline descritptions on ParentalCondistions and Authorizations to wrap properly. These are intended to be fixed in the next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, I've made the requisite changes and the PDF form fills on all questions as intended on Chrome on Linux. All methods used for grabbing data are used elsewhere in the code base so (I assume) they should be ok to use here. In addition to formatting issues that need to be fixed in future PRs, the way we handle the logic of 'I/We' filling in for multiple or single persons filling the form should be looked at and tested.