Syncing does not match ResultAggregator errors #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshsmith
force-pushed
the
syncing-does-not-match-result-aggregator-errors
branch
from
780c5f8
to
41a6ca5
Compare
|
We should use changes in #1198 as a basis for thinking about how to implement an audit log here and raise any errors in the syncing. |
joshsmith
modified the milestones:
📥 GitHub project syncing,
💅 GitHub integration polish,
🐛 Github sync bugs
begedin
force-pushed
the
develop
branch
18 times, most recently
from
e075407
to
6d6cc63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Right now this PR just has a failing test case demonstrating that syncing does not match
ResultAggregatorerrors in the form of{:error, {list, list}}.This also indicates a much larger problem lurking beneath the surface: once a project disconnects from GitHub, the sync logic when reconnecting will not work if anything has changed. Even worse, we have no way of queue up a sync of the newly re-connected tasks back up to GitHub in order to bring everything back into place.