Update player.js fix screenshot capturing subtitles #2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently only captures if user explicitly flips that options twice Screenshot subtitles are still TINY, but thats another bug :)
how come? what's the fix?
same question. used to be the right size, yet not the same flow /alignment |
can only happen after user disabled and re enabled this option. embed_subtitle is value: true, that means that the only state that matters is false.
no idea, as this was the first time I took screenshot with the extension :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently only captures if user explicitly flips that options twice
Screenshot subtitles are still TINY, but thats another bug :)