Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update skeleton.js #2165

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

Durgesh4993
Copy link

In this code code defines a skeleton structure for a web application's user interface, organized into three main sections: Base, Header, and Main.

  • Base: Sets up the base component.
  • Header: Defines components for the header section, including buttons for navigation and actions.
  • Main: Contains the main content area, with layers for navigation, and may include an iframe for displaying external content.

The code may contain potential issues related to event handling, dynamic content, conditional rendering, CSS styles, and consistency. Modifications have been made to address these issues, including adding dummy functions for event handlers and simplifying dynamic content.

@raszpl
Copy link
Contributor

raszpl commented Apr 7, 2024

This looks like your internal build changes, adding console.log logging etc while removing vital functionality (#2056)

-version
-default open search
-menu back button
-css change moving stuff out of alignment with bottom

are you sure you wanted to push this to main?

Please use Tabs instead of spaces. Cant see changes when every patch changes indentation convention :(

@ImprovedTube ImprovedTube marked this pull request as draft April 7, 2024 22:17
@ImprovedTube
Copy link
Member

Welcome back! @Durgesh4993 & thanks for caring!

Please use Tabs instead of spaces. Cant see changes when every patch changes indentation convention :(

Let's fix this everywhere @raszpl
Apparently only 15% of files have a tab key https://github.com/search?q=%22%09%22&type=code

While 68% have 4 consecutive spaces
47% 8
34% have 12 https://github.com/search?q=%22++++++++++++%22&type=code
20% 16
15% 20
11% 24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants