mysql: fixing index out of bounds in conn.go #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sravotto
force-pushed
the
sr8_issue858
branch
3 times, most recently
from
4460f79
to
121ed36
Compare
bobvawter
approved these changes
May 16, 2024
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @BramGruneir and @sravotto)
internal/source/mylogical/conn_test.go line 17 at r1 (raw file):
// SPDX-License-Identifier: Apache-2.0 // Package mylogical contains support for reading a mySQL logical
This package comment seems redundant, especially in test code.
This change fixes a panic that could be caused by rows in a stream not conforming to the schema provided in TableMapEvents. It also adds test cases to verify the functionality of onDataTuple function. Fixes #858.
sravotto
commented
May 17, 2024
There was a problem hiding this comment.
Thanks!
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @bobvawter and @BramGruneir)
internal/source/mylogical/conn_test.go line 17 at r1 (raw file):
Previously, bobvawter (Bob Vawter) wrote…
This package comment seems redundant, especially in test code.
Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a panic that could be caused by rows in a stream not conforming to the schema provided in TableMapEvents.
It also adds test cases to verify the functionality of onDataTuple function.
Fixes #858.
This change is