Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

votr: Add VOTR demonstration workload #573

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

votr: Add VOTR demonstration workload #573

wants to merge 1 commit into from

Conversation

bobvawter
Copy link
Member

@bobvawter bobvawter commented Oct 30, 2023

This change adds a demo workload that shows how the merge function can be used
to implement asynchronous, two-way and hub-and-spoke replication. A more
complete discussion of the workload is provided in its README file.

A small extension to the existing parse-helpers API is necessary to ensure that
JSONB values are reified as json-ish types when loading conflicting rows from
the database. The server.Server type also supplies its listener address so
that VOTR can automatically create changefeeds.

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

Attention: 226 lines in your changes are missing coverage. Please review.

Comparison is base (f0532f7) 75.71% compared to head (7e579b8) 67.62%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #573      +/-   ##
==========================================
- Coverage   75.71%   67.62%   -8.09%     
==========================================
  Files         164      166       +2     
  Lines       10558    11146     +588     
==========================================
- Hits         7994     7538     -456     
- Misses       1952     3054    +1102     
+ Partials      612      554      -58     
Files Coverage Δ
internal/source/server/provider.go 67.54% <100.00%> (+3.50%) ⬆️
internal/source/server/server.go 25.00% <100.00%> (+25.00%) ⬆️
internal/target/apply/apply.go 77.04% <66.66%> (-0.94%) ⬇️
internal/target/schemawatch/parse_helpers.go 53.24% <75.00%> (-14.45%) ⬇️
internal/cmd/votr/schema.go 77.07% <77.07%> (ø)
internal/cmd/votr/votr.go 55.23% <55.23%> (ø)

... and 35 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bobvawter bobvawter changed the title [WIP] Votr votr: Add VOTR demonstration workload Nov 1, 2023
@bobvawter bobvawter marked this pull request as ready for review November 2, 2023 02:27
This change adds a demo workload that shows how the merge function can be used
to implement asynchronous, two-way and hub-and-spoke replication. A more
complete discussion of the workload is provided in its README file.

A small extension to the existing parse-helpers API is necessary to ensure that
JSONB values are reified as json-ish types when loading conflicting rows from
the database. The `server.Server` type also supplies its listener address so
that VOTR can automatically create changefeeds.
Copy link
Member

@BramGruneir BramGruneir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 12 files at r2, 28 of 28 files at r5, 6 of 6 files at r6, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sravotto)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants