crl-release-24.1: ingest: avoid unnecessary I/O when checking overlap

[RaduBerinde]

This commit sets the upper bound on the level iterator used when checking for overlap. This avoids unnecessarily opening a file that starts after the key range of interest.

[cockroach-teamcity]

This change is 

[RaduBerinde]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @jbowens)

---

ingest.go line 935 at r1 (raw file):

	computeOverlapWithSpans := func(rIter keyspan.FragmentIterator) (bool, error) {
		// NB: The spans surfaced by the fragment iterator are non-overlapping.
		span, err := rIter.SeekGE(bounds.Start)

Not sure this fixes much, I think we'd still open the next file here?

---

ingest.go line 1109 at r1 (raw file):

		rkeyLevelIter.Init(
			keyspan.SpanIterOptions{}, comparer.Compare, newRangeKeyIter,
			v.Levels[level].Iter(), manifest.Level(level), manifest.KeyTypeRange,

should this be v.RangeKeyLevels?

[RaduBerinde]

ingest.go line 935 at r1 (raw file):

Previously, RaduBerinde wrote…

Not sure this fixes much, I think we'd still open the next file here?

Well.. only when there's another file on the level which range keys

[RaduBerinde]

ingest.go line 935 at r1 (raw file):

Previously, RaduBerinde wrote…

Well.. only when there's another file on the level which range keys

*with range keys

[jbowens]

Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @RaduBerinde)

---

ingest.go line 1109 at r1 (raw file):

Previously, RaduBerinde wrote…

should this be v.RangeKeyLevels?

Good catch, yeah it should be. v.Levels is still correct since it contains a superset of the files in v.RangeKeyLevels, but the keyspanimpl.LevelIter needs to potentially wade through many files with no range keys

[RaduBerinde]

TFTR!

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @jbowens)

---

ingest.go line 1109 at r1 (raw file):

Previously, jbowens (Jackson Owens) wrote…

Good catch, yeah it should be. v.Levels is still correct since it contains a superset of the files in v.RangeKeyLevels, but the keyspanimpl.LevelIter needs to potentially wade through many files with no range keys

I'll leave it as is here to minimize the changes. Shouldn't be a big deal, the keyspanimpl.LevelIter will filter out files that have no range keys.