Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-9350 DOC-9351 Docs for Log and Metric export to Azure Monitor supported for Dedicated Azure clusters #18549

Merged
merged 6 commits into from
May 17, 2024

Conversation

florence-crl
Copy link
Contributor

@florence-crl florence-crl commented May 14, 2024

Fixes DOC-9350, DOC-9351

(1) In cockroachdb-dedicated-on-azure.md, removed Observability limitations.
(2) In export-logs.md, added filter section for Azure Monitor.
(3) In export-metrics.md, added filter section for Azure Monitor.

Rendered previews
Export Logs to Azure Monitor
Export Metrics to Azure Monitor

…ations.

(2) In export-logs.md, added filter section for Azure Monitor.

(3) In export-metrics.md, added filter section for Azure Monitor.
Copy link

netlify bot commented May 14, 2024

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 96a64ad
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/664778d3a641700008e3a79b

Copy link

netlify bot commented May 14, 2024

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 96a64ad
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/664778d3166935000835a704

Copy link

netlify bot commented May 14, 2024

Netlify Preview

Name Link
🔨 Latest commit 96a64ad
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/664778d31dc5fe000860978e
😎 Deploy Preview https://deploy-preview-18549--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@florence-crl
Copy link
Contributor Author

Hi
@arjunmahishi please review Export Logs to Azure Monitor
@aa-joshi please review Export Metrics to Azure Monitor

On both pages, in the Enable section there is just a message to contact their CRL account team. In a separate PR, I will document the Enable section once I get the loom videos from you both.

Thanks.

@florence-crl florence-crl changed the title DOC-9350 Docs for Log and Metric export to Azure Monitor supported for Dedicated Azure clusters DOC-9350 DOC-9351 Docs for Log and Metric export to Azure Monitor supported for Dedicated Azure clusters May 15, 2024
@florence-crl
Copy link
Contributor Author

@mikeCRL and @kevin-v-ngo is this sufficient documentation for Azure Monitor for the 5/20 24.1 release. I will follow up with a separate PR for the Enable sections as soon as possible.

Copy link

@arjunmahishi arjunmahishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small NIt. LGTM otherwise.

src/current/cockroachcloud/export-metrics.md Outdated Show resolved Hide resolved
@florence-crl
Copy link
Contributor Author

Mike and Kevin said that this pr was sufficient for the 5/20 v24.1 release in this slack thread

Copy link
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but AWS Cloudwatch still has to be amended to Amazon Cloudwatch throughout these (& other) docs.

src/current/cockroachcloud/export-logs.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/export-logs.md Show resolved Hide resolved
src/current/cockroachcloud/export-logs.md Show resolved Hide resolved
src/current/cockroachcloud/export-logs.md Show resolved Hide resolved
src/current/cockroachcloud/export-metrics.md Show resolved Hide resolved
src/current/cockroachcloud/export-metrics.md Show resolved Hide resolved
src/current/cockroachcloud/export-metrics.md Show resolved Hide resolved
src/current/cockroachcloud/export-metrics.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTRs!

src/current/cockroachcloud/export-logs.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/export-logs.md Show resolved Hide resolved
src/current/cockroachcloud/export-logs.md Show resolved Hide resolved
src/current/cockroachcloud/export-logs.md Show resolved Hide resolved
src/current/cockroachcloud/export-metrics.md Show resolved Hide resolved
src/current/cockroachcloud/export-metrics.md Show resolved Hide resolved
src/current/cockroachcloud/export-metrics.md Show resolved Hide resolved
src/current/cockroachcloud/export-metrics.md Outdated Show resolved Hide resolved
@florence-crl florence-crl merged commit 48a0dce into main May 17, 2024
6 checks passed
@florence-crl florence-crl deleted the DOC-9350-limited-access branch May 17, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants