-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MOLT Fetch GA documentation #18541
MOLT Fetch GA documentation #18541
Conversation
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the mysql, connection, and type mapping part. Defer the rest to Jeremy and Ryan for they have more context on those topics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this: continuation tokens, mysql sharding, and ongoing replication sections look ready to go.
I do want to note that some of the flags I'm introducing will be required in the command running examples.
Additionally, I'll make a follow up ticket to document all the security recommendations we make. Maybe we can just make this a security
section.
TFTRs everyone. Passing this on to docs review and I'll fast-follow with a PR to address the new required flags @ryanluu12345 mentioned above. |
@taroface I put all the follow up security documentation here: https://cockroachlabs.atlassian.net/browse/DOC-10306?atlOrigin=eyJpIjoiYTFlYzljN2EyMDc1NGJhMTk5NWZlNDI0NDc4NjFkNWMiLCJwIjoiamlyYS1zbGFjay1pbnQifQ Let's just do a follow up PR as to not block this |
Co-authored-by: Matt Linville (he/him) <linville@cockroachlabs.com>
DOC-10188
DOC-10189
DOC-10262
DOC-10263
DOC-10190
DOC-10265
DOC-10234