Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOLT Fetch GA documentation #18541

Merged
merged 10 commits into from
May 17, 2024
Merged

MOLT Fetch GA documentation #18541

merged 10 commits into from
May 17, 2024

Conversation

taroface
Copy link
Contributor

@taroface taroface commented May 13, 2024

DOC-10188
DOC-10189
DOC-10262
DOC-10263
DOC-10190
DOC-10265
DOC-10234

  • Updates to continuation tokens
  • Replicator functionality
  • Type mappings
  • MySQL concurrency
  • Connection lifetime recommendations
  • Fetch and Verify required permissions

Copy link

github-actions bot commented May 13, 2024

Copy link

netlify bot commented May 13, 2024

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit d50776a
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/664787410da9670008416ec8

Copy link

netlify bot commented May 13, 2024

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit d50776a
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/66478742be70b20008ae05ff

Copy link

netlify bot commented May 13, 2024

Netlify Preview

Name Link
🔨 Latest commit d50776a
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/66478741cbfaa600085d138a
😎 Deploy Preview https://deploy-preview-18541--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@taroface taroface changed the title [WIP] MOLT Fetch GA documentation MOLT Fetch GA documentation May 15, 2024
Copy link

@ZhouXing19 ZhouXing19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the mysql, connection, and type mapping part. Defer the rest to Jeremy and Ryan for they have more context on those topics

src/current/v24.1/molt-fetch.md Outdated Show resolved Hide resolved
src/current/v24.1/molt-fetch.md Outdated Show resolved Hide resolved
src/current/v24.1/molt-fetch.md Outdated Show resolved Hide resolved
src/current/v24.1/molt-fetch.md Show resolved Hide resolved
Copy link

@ryanluu12345 ryanluu12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this: continuation tokens, mysql sharding, and ongoing replication sections look ready to go.

I do want to note that some of the flags I'm introducing will be required in the command running examples.

Additionally, I'll make a follow up ticket to document all the security recommendations we make. Maybe we can just make this a security section.

@taroface
Copy link
Contributor Author

TFTRs everyone. Passing this on to docs review and I'll fast-follow with a PR to address the new required flags @ryanluu12345 mentioned above.

@taroface taroface requested a review from mdlinville May 16, 2024 19:50
src/current/v24.1/molt-fetch.md Show resolved Hide resolved
src/current/v24.1/molt-fetch.md Show resolved Hide resolved
src/current/v24.1/molt-fetch.md Outdated Show resolved Hide resolved
src/current/v24.1/molt-fetch.md Outdated Show resolved Hide resolved
src/current/v24.1/molt-fetch.md Outdated Show resolved Hide resolved
src/current/v24.1/molt-fetch.md Show resolved Hide resolved
src/current/v24.1/molt-fetch.md Show resolved Hide resolved
src/current/v24.1/molt-fetch.md Outdated Show resolved Hide resolved
src/current/v24.1/molt-fetch.md Show resolved Hide resolved
src/current/v24.1/molt-verify.md Outdated Show resolved Hide resolved
@ryanluu12345
Copy link

Great work on this: continuation tokens, mysql sharding, and ongoing replication sections look ready to go.

I do want to note that some of the flags I'm introducing will be required in the command running examples.

Additionally, I'll make a follow up ticket to document all the security recommendations we make. Maybe we can just make this a security section.

@taroface I put all the follow up security documentation here: https://cockroachlabs.atlassian.net/browse/DOC-10306?atlOrigin=eyJpIjoiYTFlYzljN2EyMDc1NGJhMTk5NWZlNDI0NDc4NjFkNWMiLCJwIjoiamlyYS1zbGFjay1pbnQifQ

Let's just do a follow up PR as to not block this

taroface and others added 2 commits May 17, 2024 12:19
Co-authored-by: Matt Linville (he/him) <linville@cockroachlabs.com>
@taroface taroface enabled auto-merge (squash) May 17, 2024 16:35
@taroface taroface merged commit c06eef5 into main May 17, 2024
6 checks passed
@taroface taroface deleted the molt-fetch-GA branch May 17, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants