-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachtest: add a new cdc/kafka-chaos-single-row test #124313
Conversation
This PR depends on #124195 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @andyyang890, @asg0451, @nameisbhaskar, and @vidit-bhat)
pkg/cmd/roachtest/tests/cdc.go
line 1578 at r5 (raw file):
Leases: registry.MetamorphicLeases, CompatibleClouds: registry.AllExceptAWS, // TODO(yang): Add this to the nightly test suite after we fix the Kafka restart bug.
nit: s/yang/#122372
pkg/cmd/roachtest/tests/cdc.go
line 1626 at r5 (raw file):
stmt := fmt.Sprintf(`UPDATE t SET x = %d WHERE id = 1;`, i) if i == 0 { stmt = fmt.Sprintf(`INSERT INTO t VALUES (1, %d);`, i)
Consider lifting the insert statement and its execution out of the loop.
Please wait for @asg0451 to have a chance to review before merging. Thanks! |
0bd0c44
to
859b31a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @asg0451, @nameisbhaskar, @rharding6373, and @vidit-bhat)
pkg/cmd/roachtest/tests/cdc.go
line 1578 at r5 (raw file):
Previously, rharding6373 (Rachael Harding) wrote…
nit: s/yang/#122372
Done.
pkg/cmd/roachtest/tests/cdc.go
line 1626 at r5 (raw file):
Previously, rharding6373 (Rachael Harding) wrote…
Consider lifting the insert statement and its execution out of the loop.
Done.
859b31a
to
944f9ec
Compare
This patch adds a new `cdc/kafka-chaos-single-row` roachtest, which will serve as a regression test for the Kafka restarts bug. It is currently configured to only be able to run manually since we have not yet fixed the bug. Release note: None
944f9ec
to
902fb69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 4 files at r6, 1 of 1 files at r7, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @nameisbhaskar, @rharding6373, and @vidit-bhat)
TFTRs! bors r=rharding6373,asg0451 |
This patch adds a new
cdc/kafka-chaos-single-row
roachtest, whichwill serve as a regression test for the Kafka restarts bug. It is
currently configured to only be able to run manually since we have not
yet fixed the bug.
Informs #122372
Release note: None