Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.1: ui: fix replication lag metric for multinode clusters and cutover #123585

Merged
merged 1 commit into from
May 6, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented May 3, 2024

Backport 1/1 commits from #123510 on behalf of @kev-cao.

/cc @cockroachdb/release


Replication lag metric would report absurdly high lag for multinode clusters as it would take the average of the reported timestamps, and as some nodes may report 0, this would cause extremely low replicated times. To resolve this, the metric should pick the maximum time reported by all of the nodes. Additionally, on cutover or job fail/cancellation, stop reporting replicated time to avoid falsely reporting high replication lag.

Informs #120652

Release note (ui change): fix replication lag metric reporting for multinode clusters and cutover


Release justification: current replication lag metric reports incorrectly for multinode clusters

Replication lag metric would report absurdly high lag for multinode
clusters as it would take the average of the reported timestamps, and as
some nodes may report 0, this would cause extremely low replicated
times. To resolve this, the metric should pick the maximum time reported
by all of the nodes. Additionally, on cutover or job fail/cancellation,
replicated time has stopped being reported to avoid falsely reporting
high replication lag.

Informs #120652

Release note (ui change): fix replication lag metric reporting for multinode
clusters and cutover
@blathers-crl blathers-crl bot requested a review from a team as a code owner May 3, 2024 18:58
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.1-123510 branch from 1429e96 to a3b0ed1 Compare May 3, 2024 18:58
@blathers-crl blathers-crl bot requested a review from a team as a code owner May 3, 2024 18:58
@blathers-crl blathers-crl bot requested review from xinhaoz and removed request for a team May 3, 2024 18:58
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels May 3, 2024
@blathers-crl blathers-crl bot requested review from msbutler and removed request for a team May 3, 2024 18:58
@blathers-crl blathers-crl bot requested a review from kev-cao May 3, 2024 18:58
Copy link
Author

blathers-crl bot commented May 3, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label May 3, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@dhartunian dhartunian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @kev-cao, @msbutler, and @xinhaoz)

@dt dt merged commit d885b24 into release-24.1 May 6, 2024
19 of 20 checks passed
@dt dt deleted the blathers/backport-release-24.1-123510 branch May 6, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants