Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeedccl: make mock pulsar sink synchronous #123228

Merged
merged 1 commit into from
May 6, 2024

Commits on May 4, 2024

  1. changefeedccl: make mock pulsar sink synchronous

    Although the comments in mock pulsar sink say that emitting messages and
    flushing are synchronous, the use of a buffered channel to transmit
    messages from the mock producer to the test feed makes it asynchronous.
    This leads to problems where the consumer (the test) may not have stored
    the data in a "durable" way before the changefeed job completes. As a
    result, tests can be flaky as it does not always look like all rows have
    been emitted.
    
    This PR makes the mock pulsar sink synchronous by using an unbuffered
    channel.
    
    Fixes: cockroachdb#119289
    Informs: cockroachdb#118899
    
    Epic: CRDB-9180
    
    Release note: None
    rharding6373 committed May 4, 2024
    Configuration menu
    Copy the full SHA
    97dcb3d View commit details
    Browse the repository at this point in the history