streamingccl: replicate manual split points #123225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
msbutler
requested review from
dt and
stevendanna
and removed request for
a team
This comment was marked as outdated.
This comment was marked as outdated.
msbutler
commented
Apr 29, 2024
msbutler
force-pushed
the
butler-split-pcr-event
branch
from
bd1a600
to
2318f28
Compare
dt
approved these changes
Apr 30, 2024
msbutler
force-pushed
the
butler-split-pcr-event
branch
from
2318f28
to
7dbeaaa
Compare
|
TFTR! bors r=dt |
|
Build failed: |
msbutler
force-pushed
the
butler-split-pcr-event
branch
from
7dbeaaa
to
4f48076
Compare
This patch teaches PCR to replicate source cluster manual split points to the destination cluster. Specifically, this patch configures the event_stream rangefeeds to emit rangefeed metadata events that indicate if a rangefeed spawned due to a manual split. Then, the event stream sends the manual split key over to the destination cluster. Informs cockroachdb#122846 Release note: none
msbutler
force-pushed
the
butler-split-pcr-event
branch
from
4f48076
to
2f031b1
Compare
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch teaches PCR to replicate source cluster manual split points to the
destination cluster. Specifically, this patch configures the event_stream
rangefeeds to emit rangefeed metadata events that indicate if a rangefeed
spawned due to a manual split. Then, the event stream sends the manual split
key over to the destination cluster.
Informs #122846
Release note: none