New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.2: server: don't redact jemalloc stats #123221
release-23.2: server: don't redact jemalloc stats #123221
Conversation
1f8b1e9
to
8b5f8a4
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
These stats can be useful to debug customer issues. They can be temporarily enabled on a node using `SELECT crdb_internal.set_vmodule('runtime_jemalloc=3')` There is no sensitive data in the stats, they look like this: ``` jemalloc stats: allocated: 6.0 GiB, active: 6.3 GiB, metadata: 161 MiB, resident: 7.1 GiB, mapped: 8.6 GiB ``` Release note: None Epic: none
8b5f8a4
to
52011c8
Compare
Backport 1/1 commits from #123169 on behalf of @RaduBerinde.
Release justification: trivial change to avoid redaction of jemalloc stats in logs.
/cc @cockroachdb/release
These stats can be useful to debug customer issues. They can be
temporarily enabled on a node using
SELECT crdb_internal.set_vmodule('runtime_jemalloc=3')
There is no sensitive data in the stats, they look like this:
Release note: None
Epic: none
Release justification: