concurrency: add ConcurrencyManager test for lock promotion deadlocks #123209
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @arulajmani)
pkg/kv/kvserver/concurrency/testdata/concurrency_manager/shared_locks line 1425 at r1 (raw file):
[4] sequence req4: dependency cycle detected 00000002->00000001->00000002 # We can't break the deadlock and get deterministic behaviour unfortunately.
Can we at least reset after this point so that we can add more test cases to this file?
There was a problem hiding this comment.
Reviewable status:
pkg/kv/kvserver/concurrency/testdata/concurrency_manager/shared_locks line 1425 at r1 (raw file):
Previously, nvanbenschoten (Nathan VanBenschoten) wrote…
Can we at least
resetafter this point so that we can add more test cases to this file?
Unfortunately we can't because req3 and req4 are still in-flight. How do you feel about moving this to its own file instead?
There was a problem hiding this comment.
Reviewable status:
pkg/kv/kvserver/concurrency/testdata/concurrency_manager/shared_locks line 1425 at r1 (raw file):
Previously, arulajmani (Arul Ajmani) wrote…
Unfortunately we can't because req3 and req4 are still in-flight. How do you feel about moving this to its own file instead?
Moving to its own file SGTM.
Closes cockroachdb#109634 Release note: None
arulajmani
force-pushed
the
shared-locks-concurrency-manager-tests
branch
from
30248f6
to
5f51f8d
Compare
There was a problem hiding this comment.
TFTR!
bors r+
Reviewable status:
pkg/kv/kvserver/concurrency/testdata/concurrency_manager/shared_locks line 1425 at r1 (raw file):
Previously, nvanbenschoten (Nathan VanBenschoten) wrote…
Moving to its own file SGTM.
Not sure how I only caught this just now, but the test was failing because of these leaked in-flight goroutines. To get around this, I had to add a "force" modifier to cancel the context on these inflight goroutines instead. With that, we can keep these in this file.
Closes #109634
Release note: None