Skip to content

Commit

Permalink
Merge pull request #118678 from cockroachdb/blathers/backport-staging…
Browse files Browse the repository at this point in the history
…-v22.2.18-117319

staging-v22.2.18: roachtest: replace gs://cockroach-fixtures with gs://cockroach-fixtures-us-east1
  • Loading branch information
celiala committed Feb 2, 2024
2 parents e85306f + db8d45c commit 7c7aabc
Show file tree
Hide file tree
Showing 20 changed files with 168 additions and 167 deletions.
2 changes: 1 addition & 1 deletion pkg/ccl/workloadccl/cliccl/fixtures.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import (
var defaultConfig = workloadccl.FixtureConfig{
StorageProvider: "gs",
AuthParams: "AUTH=implicit",
Bucket: `cockroach-fixtures`,
Bucket: `cockroach-fixtures-us-east1`,
Basename: `workload`,
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/cli/interactive_tests/test_workload.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ end_test

start_test "Sanity check workload fixtures url."
send "$argv workload fixtures url tpcc\r"
eexpect "gs://cockroach-fixtures/workload/tpcc"
eexpect "gs://cockroach-fixtures-us-east1/workload/tpcc"
end_test

# Clean up.
Expand Down
12 changes: 6 additions & 6 deletions pkg/cloud/gcp/gcs_storage_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ func TestFileDoesNotExist(t *testing.T) {

{
// Invalid gsFile.
gsFile := "gs://cockroach-fixtures/tpch-csv/sf-1/invalid_region.tbl?AUTH=implicit"
gsFile := "gs://cockroach-fixtures-us-east1/tpch-csv/sf-1/invalid_region.tbl?AUTH=implicit"
conf, err := cloud.ExternalStorageConfFromURI(gsFile, user)
require.NoError(t, err)

Expand All @@ -397,7 +397,7 @@ func TestFileDoesNotExist(t *testing.T) {

{
// Invalid gsBucket.
gsFile := "gs://cockroach-fixtures-invalid/tpch-csv/sf-1/region.tbl?AUTH=implicit"
gsFile := "gs://cockroach-fixtures-us-east1-invalid/tpch-csv/sf-1/region.tbl?AUTH=implicit"
conf, err := cloud.ExternalStorageConfFromURI(gsFile, user)
require.NoError(t, err)

Expand Down Expand Up @@ -428,11 +428,11 @@ func TestCompressedGCS(t *testing.T) {

testSettings := cluster.MakeTestingClusterSettings()

// gsutil cp /usr/share/dict/words gs://cockroach-fixtures/words-compressed.txt
gsFile1 := "gs://cockroach-fixtures/words.txt?AUTH=implicit"
// gsutil cp /usr/share/dict/words gs://cockroach-fixtures-us-east1/words-compressed.txt
gsFile1 := "gs://cockroach-fixtures-us-east1/words.txt?AUTH=implicit"

// gsutil cp -Z /usr/share/dict/words gs://cockroach-fixtures/words-compressed.txt
gsFile2 := "gs://cockroach-fixtures/words-compressed.txt?AUTH=implicit"
// gsutil cp -Z /usr/share/dict/words gs://cockroach-fixtures-us-east1/words-compressed.txt
gsFile2 := "gs://cockroach-fixtures-us-east1/words-compressed.txt?AUTH=implicit"

conf1, err := cloud.ExternalStorageConfFromURI(gsFile1, user)
require.NoError(t, err)
Expand Down
20 changes: 10 additions & 10 deletions pkg/cmd/roachtest/tests/backup.go
Original file line number Diff line number Diff line change
Expand Up @@ -1115,7 +1115,7 @@ func registerBackup(r registry.Registry) {
EncryptionSupport: registry.EncryptionMetamorphic,
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
if c.Spec().Cloud != spec.GCE {
t.Skip("uses gs://cockroach-fixtures; see https://github.com/cockroachdb/cockroach/issues/105968")
t.Skip("uses gs://cockroach-fixtures-us-east1; see https://github.com/cockroachdb/cockroach/issues/105968")
}
runBackupMVCCRangeTombstones(ctx, t, c)
},
Expand Down Expand Up @@ -1168,7 +1168,7 @@ revert=2'`)
_, err = conn.Exec(`USE tpch`)
require.NoError(t, err)
createStmt, err := readCreateTableFromFixture(
"gs://cockroach-fixtures/tpch-csv/schema/orders.sql?AUTH=implicit", conn)
"gs://cockroach-fixtures-us-east1/tpch-csv/schema/orders.sql?AUTH=implicit", conn)
require.NoError(t, err)
_, err = conn.ExecContext(ctx, createStmt)
require.NoError(t, err)
Expand Down Expand Up @@ -1232,10 +1232,10 @@ revert=2'`)
// Import the odd-numbered files.
t.Status("importing odd-numbered files")
files := []string{
`gs://cockroach-fixtures/tpch-csv/sf-100/orders.tbl.1?AUTH=implicit`,
`gs://cockroach-fixtures/tpch-csv/sf-100/orders.tbl.3?AUTH=implicit`,
`gs://cockroach-fixtures/tpch-csv/sf-100/orders.tbl.5?AUTH=implicit`,
`gs://cockroach-fixtures/tpch-csv/sf-100/orders.tbl.7?AUTH=implicit`,
`gs://cockroach-fixtures-us-east1/tpch-csv/sf-100/orders.tbl.1?AUTH=implicit`,
`gs://cockroach-fixtures-us-east1/tpch-csv/sf-100/orders.tbl.3?AUTH=implicit`,
`gs://cockroach-fixtures-us-east1/tpch-csv/sf-100/orders.tbl.5?AUTH=implicit`,
`gs://cockroach-fixtures-us-east1/tpch-csv/sf-100/orders.tbl.7?AUTH=implicit`,
}
_, err = conn.ExecContext(ctx, fmt.Sprintf(
`IMPORT INTO orders CSV DATA ('%s') WITH delimiter='|'`, strings.Join(files, "', '")))
Expand All @@ -1258,10 +1258,10 @@ revert=2'`)

// Import and cancel even-numbered files twice.
files = []string{
`gs://cockroach-fixtures/tpch-csv/sf-100/orders.tbl.2?AUTH=implicit`,
`gs://cockroach-fixtures/tpch-csv/sf-100/orders.tbl.4?AUTH=implicit`,
`gs://cockroach-fixtures/tpch-csv/sf-100/orders.tbl.6?AUTH=implicit`,
`gs://cockroach-fixtures/tpch-csv/sf-100/orders.tbl.8?AUTH=implicit`,
`gs://cockroach-fixtures-us-east1/tpch-csv/sf-100/orders.tbl.2?AUTH=implicit`,
`gs://cockroach-fixtures-us-east1/tpch-csv/sf-100/orders.tbl.4?AUTH=implicit`,
`gs://cockroach-fixtures-us-east1/tpch-csv/sf-100/orders.tbl.6?AUTH=implicit`,
`gs://cockroach-fixtures-us-east1/tpch-csv/sf-100/orders.tbl.8?AUTH=implicit`,
}

_, err = conn.ExecContext(ctx,
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/copy.go
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ func registerCopy(r registry.Registry) {
Cluster: r.MakeClusterSpec(tc.nodes),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
if c.Spec().Cloud != spec.GCE {
t.Skip("uses gs://cockroach-fixtures; see https://github.com/cockroachdb/cockroach/issues/105968")
t.Skip("uses gs://cockroach-fixtures-us-east1; see https://github.com/cockroachdb/cockroach/issues/105968")
}
runCopy(ctx, t, c, tc.rows, tc.txn)
},
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/copyfrom.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import (
"github.com/stretchr/testify/require"
)

const tpchLineitemFmt = `https://storage.googleapis.com/cockroach-fixtures/tpch-csv/sf-%d/lineitem.tbl.1`
const tpchLineitemFmt = `https://storage.googleapis.com/cockroach-fixtures-us-east1/tpch-csv/sf-%d/lineitem.tbl.1`

// There's an extra dummy field because the file above ends lines with delimiter and standard CSV behavior is to
// interpret that as a column.
Expand Down
42 changes: 21 additions & 21 deletions pkg/cmd/roachtest/tests/import.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,21 +51,21 @@ func registerImportNodeShutdown(r registry.Registry) {
importStmt := fmt.Sprintf(`
IMPORT INTO %[1]s
CSV DATA (
'gs://cockroach-fixtures/tpch-csv/sf-100/%[1]s.tbl.1?AUTH=implicit',
'gs://cockroach-fixtures/tpch-csv/sf-100/%[1]s.tbl.2?AUTH=implicit',
'gs://cockroach-fixtures/tpch-csv/sf-100/%[1]s.tbl.3?AUTH=implicit',
'gs://cockroach-fixtures/tpch-csv/sf-100/%[1]s.tbl.4?AUTH=implicit',
'gs://cockroach-fixtures/tpch-csv/sf-100/%[1]s.tbl.5?AUTH=implicit',
'gs://cockroach-fixtures/tpch-csv/sf-100/%[1]s.tbl.6?AUTH=implicit',
'gs://cockroach-fixtures/tpch-csv/sf-100/%[1]s.tbl.7?AUTH=implicit',
'gs://cockroach-fixtures/tpch-csv/sf-100/%[1]s.tbl.8?AUTH=implicit'
'gs://cockroach-fixtures-us-east1/tpch-csv/sf-100/%[1]s.tbl.1?AUTH=implicit',
'gs://cockroach-fixtures-us-east1/tpch-csv/sf-100/%[1]s.tbl.2?AUTH=implicit',
'gs://cockroach-fixtures-us-east1/tpch-csv/sf-100/%[1]s.tbl.3?AUTH=implicit',
'gs://cockroach-fixtures-us-east1/tpch-csv/sf-100/%[1]s.tbl.4?AUTH=implicit',
'gs://cockroach-fixtures-us-east1/tpch-csv/sf-100/%[1]s.tbl.5?AUTH=implicit',
'gs://cockroach-fixtures-us-east1/tpch-csv/sf-100/%[1]s.tbl.6?AUTH=implicit',
'gs://cockroach-fixtures-us-east1/tpch-csv/sf-100/%[1]s.tbl.7?AUTH=implicit',
'gs://cockroach-fixtures-us-east1/tpch-csv/sf-100/%[1]s.tbl.8?AUTH=implicit'
) WITH delimiter='|', detached
`, tableName)
gatewayDB := c.Conn(ctx, t.L(), gatewayNode)
defer gatewayDB.Close()

createStmt, err := readCreateTableFromFixture(
fmt.Sprintf("gs://cockroach-fixtures/tpch-csv/schema/%s.sql?AUTH=implicit", tableName), gatewayDB)
fmt.Sprintf("gs://cockroach-fixtures-us-east1/tpch-csv/schema/%s.sql?AUTH=implicit", tableName), gatewayDB)
if err != nil {
return "", err
}
Expand All @@ -88,7 +88,7 @@ func registerImportNodeShutdown(r registry.Registry) {
Cluster: r.MakeClusterSpec(4),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
if c.Spec().Cloud != spec.GCE {
t.Skip("uses gs://cockroach-fixtures; see https://github.com/cockroachdb/cockroach/issues/105968")
t.Skip("uses gs://cockroach-fixtures-us-east1; see https://github.com/cockroachdb/cockroach/issues/105968")
}
c.Put(ctx, t.Cockroach(), "./cockroach")
c.Start(ctx, t.L(), option.DefaultStartOpts(), install.MakeClusterSettings())
Expand All @@ -105,7 +105,7 @@ func registerImportNodeShutdown(r registry.Registry) {
Cluster: r.MakeClusterSpec(4),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
if c.Spec().Cloud != spec.GCE {
t.Skip("uses gs://cockroach-fixtures; see https://github.com/cockroachdb/cockroach/issues/105968")
t.Skip("uses gs://cockroach-fixtures-us-east1; see https://github.com/cockroachdb/cockroach/issues/105968")
}
c.Put(ctx, t.Cockroach(), "./cockroach")
c.Start(ctx, t.L(), option.DefaultStartOpts(), install.MakeClusterSettings())
Expand Down Expand Up @@ -220,7 +220,7 @@ func registerImportTPCH(r registry.Registry) {
EncryptionSupport: registry.EncryptionMetamorphic,
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
if c.Spec().Cloud != spec.GCE {
t.Skip("uses gs://cockroach-fixtures; see https://github.com/cockroachdb/cockroach/issues/105968")
t.Skip("uses gs://cockroach-fixtures-us-east1; see https://github.com/cockroachdb/cockroach/issues/105968")
}
tick, perfBuf := initBulkJobPerfArtifacts(t.Name(), item.timeout)

Expand Down Expand Up @@ -276,7 +276,7 @@ func registerImportTPCH(r registry.Registry) {
defer t.WorkerStatus()

createStmt, err := readCreateTableFromFixture(
"gs://cockroach-fixtures/tpch-csv/schema/lineitem.sql?AUTH=implicit", conn)
"gs://cockroach-fixtures-us-east1/tpch-csv/schema/lineitem.sql?AUTH=implicit", conn)
if err != nil {
return err
}
Expand All @@ -293,14 +293,14 @@ func registerImportTPCH(r registry.Registry) {
_, err = conn.Exec(`
IMPORT INTO csv.lineitem
CSV DATA (
'gs://cockroach-fixtures/tpch-csv/sf-100/lineitem.tbl.1?AUTH=implicit',
'gs://cockroach-fixtures/tpch-csv/sf-100/lineitem.tbl.2?AUTH=implicit',
'gs://cockroach-fixtures/tpch-csv/sf-100/lineitem.tbl.3?AUTH=implicit',
'gs://cockroach-fixtures/tpch-csv/sf-100/lineitem.tbl.4?AUTH=implicit',
'gs://cockroach-fixtures/tpch-csv/sf-100/lineitem.tbl.5?AUTH=implicit',
'gs://cockroach-fixtures/tpch-csv/sf-100/lineitem.tbl.6?AUTH=implicit',
'gs://cockroach-fixtures/tpch-csv/sf-100/lineitem.tbl.7?AUTH=implicit',
'gs://cockroach-fixtures/tpch-csv/sf-100/lineitem.tbl.8?AUTH=implicit'
'gs://cockroach-fixtures-us-east1/tpch-csv/sf-100/lineitem.tbl.1?AUTH=implicit',
'gs://cockroach-fixtures-us-east1/tpch-csv/sf-100/lineitem.tbl.2?AUTH=implicit',
'gs://cockroach-fixtures-us-east1/tpch-csv/sf-100/lineitem.tbl.3?AUTH=implicit',
'gs://cockroach-fixtures-us-east1/tpch-csv/sf-100/lineitem.tbl.4?AUTH=implicit',
'gs://cockroach-fixtures-us-east1/tpch-csv/sf-100/lineitem.tbl.5?AUTH=implicit',
'gs://cockroach-fixtures-us-east1/tpch-csv/sf-100/lineitem.tbl.6?AUTH=implicit',
'gs://cockroach-fixtures-us-east1/tpch-csv/sf-100/lineitem.tbl.7?AUTH=implicit',
'gs://cockroach-fixtures-us-east1/tpch-csv/sf-100/lineitem.tbl.8?AUTH=implicit'
) WITH delimiter='|'
`)
if err != nil {
Expand Down
8 changes: 4 additions & 4 deletions pkg/cmd/roachtest/tests/import_cancellation.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func registerImportCancellation(r registry.Registry) {
Cluster: r.MakeClusterSpec(6, spec.CPU(32)),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
if c.Spec().Cloud != spec.GCE {
t.Skip("uses gs://cockroach-fixtures; see https://github.com/cockroachdb/cockroach/issues/105968")
t.Skip("uses gs://cockroach-fixtures-us-east1; see https://github.com/cockroachdb/cockroach/issues/105968")
}
runImportCancellation(ctx, t, c, rangeTombstones)
},
Expand Down Expand Up @@ -110,7 +110,7 @@ func runImportCancellation(
"lineitem": 2,
}
for tbl := range tablesToNumFiles {
fixtureURL := fmt.Sprintf("gs://cockroach-fixtures/tpch-csv/schema/%s.sql?AUTH=implicit", tbl)
fixtureURL := fmt.Sprintf("gs://cockroach-fixtures-us-east1/tpch-csv/schema/%s.sql?AUTH=implicit", tbl)
createStmt, err := readCreateTableFromFixture(fixtureURL, conn)
if err != nil {
t.Fatal(err)
Expand Down Expand Up @@ -201,9 +201,9 @@ func (t *importCancellationTest) makeFilename(tableName string, number int, numF
// Tables with more than one files have the number as a suffix on the
// filename, `<tablename>.tbl.1`. Tables with a single file do not.
if numFiles > 1 {
return fmt.Sprintf(`'gs://cockroach-fixtures/tpch-csv/sf-100/%[1]s.tbl.%[2]d?AUTH=implicit'`, tableName, number)
return fmt.Sprintf(`'gs://cockroach-fixtures-us-east1/tpch-csv/sf-100/%[1]s.tbl.%[2]d?AUTH=implicit'`, tableName, number)
}
return fmt.Sprintf(`'gs://cockroach-fixtures/tpch-csv/sf-100/%[1]s.tbl?AUTH=implicit'`, tableName)
return fmt.Sprintf(`'gs://cockroach-fixtures-us-east1/tpch-csv/sf-100/%[1]s.tbl?AUTH=implicit'`, tableName)
}

func (t *importCancellationTest) runImportSequence(
Expand Down
6 changes: 3 additions & 3 deletions pkg/cmd/roachtest/tests/restore.go
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ func registerRestoreNodeShutdown(r registry.Registry) {

// 10 GiB restore.
restoreQuery := `RESTORE bank.bank FROM
'gs://cockroach-fixtures/workload/bank/version=1.0.0,payload-bytes=100,ranges=10,rows=10000000,seed=1/bank?AUTH=implicit'`
'gs://cockroach-fixtures-us-east1/workload/bank/version=1.0.0,payload-bytes=100,ranges=10,rows=10000000,seed=1/bank?AUTH=implicit'`

t.L().Printf("starting to run the restore job")
if _, err := gatewayDB.Exec(restoreQuery); err != nil {
Expand Down Expand Up @@ -347,7 +347,7 @@ func (dataBank2TB) runRestore(ctx context.Context, c cluster.Cluster) {
c.Run(ctx, c.Node(1), `./cockroach sql --insecure -e "CREATE DATABASE restore2tb"`)
c.Run(ctx, c.Node(1), `./cockroach sql --insecure -e "
RESTORE csv.bank FROM
'gs://cockroach-fixtures/workload/bank/version=1.0.0,payload-bytes=10240,ranges=0,rows=65104166,seed=1/bank?AUTH=implicit'
'gs://cockroach-fixtures-us-east1/workload/bank/version=1.0.0,payload-bytes=10240,ranges=0,rows=65104166,seed=1/bank?AUTH=implicit'
WITH into_db = 'restore2tb'"`)
}

Expand All @@ -357,7 +357,7 @@ func (dataBank2TB) runRestoreDetached(
c.Run(ctx, c.Node(1), `./cockroach sql --insecure -e "CREATE DATABASE restore2tb"`)
c.Run(ctx, c.Node(1), `./cockroach sql --insecure -e "
RESTORE csv.bank FROM
'gs://cockroach-fixtures/workload/bank/version=1.0.0,payload-bytes=10240,ranges=0,rows=65104166,seed=1/bank?AUTH=implicit'
'gs://cockroach-fixtures-us-east1/workload/bank/version=1.0.0,payload-bytes=10240,ranges=0,rows=65104166,seed=1/bank?AUTH=implicit'
WITH into_db = 'restore2tb', detached"`)
db, err := c.ConnE(ctx, t.L(), c.Node(1)[0])
if err != nil {
Expand Down
4 changes: 2 additions & 2 deletions pkg/cmd/roachtest/tests/schemachange.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ func registerSchemaChangeDuringKV(r registry.Registry) {
Cluster: r.MakeClusterSpec(5),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
if c.Spec().Cloud != spec.GCE {
t.Skip("uses gs://cockroach-fixtures; see https://github.com/cockroachdb/cockroach/issues/105968")
t.Skip("uses gs://cockroach-fixtures-us-east1; see https://github.com/cockroachdb/cockroach/issues/105968")
}
const fixturePath = `gs://cockroach-fixtures/workload/tpch/scalefactor=10/backup?AUTH=implicit`
const fixturePath = `gs://cockroach-fixtures-us-east1/workload/tpch/scalefactor=10/backup?AUTH=implicit`

c.Put(ctx, t.Cockroach(), "./cockroach")
c.Put(ctx, t.DeprecatedWorkload(), "./workload")
Expand Down
6 changes: 3 additions & 3 deletions pkg/cmd/roachtest/tests/sqlsmith.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ func registerSQLSmith(r registry.Registry) {
"seed": sqlsmith.Setups["seed"],
sqlsmith.RandTableSetupName: sqlsmith.Setups[sqlsmith.RandTableSetupName],
"tpch-sf1": func(r *rand.Rand) []string {
return []string{`RESTORE TABLE tpch.* FROM 'gs://cockroach-fixtures/workload/tpch/scalefactor=1/backup?AUTH=implicit' WITH into_db = 'defaultdb';`}
return []string{`RESTORE TABLE tpch.* FROM 'gs://cockroach-fixtures-us-east1/workload/tpch/scalefactor=1/backup?AUTH=implicit' WITH into_db = 'defaultdb';`}
},
"tpcc": func(r *rand.Rand) []string {
const version = "version=2.1.0,fks=true,interleaved=false,seed=1,warehouses=1"
Expand All @@ -54,7 +54,7 @@ func registerSQLSmith(r registry.Registry) {
} {
stmts = append(
stmts,
fmt.Sprintf("RESTORE TABLE tpcc.%s FROM 'gs://cockroach-fixtures/workload/tpcc/%[2]s/%[1]s?AUTH=implicit' WITH into_db = 'defaultdb';",
fmt.Sprintf("RESTORE TABLE tpcc.%s FROM 'gs://cockroach-fixtures-us-east1/workload/tpcc/%[2]s/%[1]s?AUTH=implicit' WITH into_db = 'defaultdb';",
t, version,
),
)
Expand Down Expand Up @@ -310,7 +310,7 @@ INSERT INTO seed_mr_table DEFAULT VALUES;`, regionList[0]),
NonReleaseBlocker: true,
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
if c.Spec().Cloud != spec.GCE {
t.Skip("uses gs://cockroach-fixtures; see https://github.com/cockroachdb/cockroach/issues/105968")
t.Skip("uses gs://cockroach-fixtures-us-east1; see https://github.com/cockroachdb/cockroach/issues/105968")
}
runSQLSmith(ctx, t, c, setup, setting)
},
Expand Down
4 changes: 2 additions & 2 deletions pkg/cmd/roachtest/tests/tpc_utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func loadTPCHDataset(
disableMergeQueue bool,
) (retErr error) {
if c.Spec().Cloud != spec.GCE {
t.Skip("uses gs://cockroach-fixtures; see https://github.com/cockroachdb/cockroach/issues/105968")
t.Skip("uses gs://cockroach-fixtures-us-east1; see https://github.com/cockroachdb/cockroach/issues/105968")
}

_, err := db.Exec("SET CLUSTER SETTING sql.stats.automatic_collection.enabled = false;")
Expand Down Expand Up @@ -108,7 +108,7 @@ func loadTPCHDataset(
if _, err := db.ExecContext(ctx, "SET CLUSTER SETTING backup.restore_span.target_size = '64MiB';"); err != nil {
return err
}
tpchURL := fmt.Sprintf("gs://cockroach-fixtures/workload/tpch/scalefactor=%d/backup?AUTH=implicit", sf)
tpchURL := fmt.Sprintf("gs://cockroach-fixtures-us-east1/workload/tpch/scalefactor=%d/backup?AUTH=implicit", sf)
if _, err := db.ExecContext(ctx, `CREATE DATABASE IF NOT EXISTS tpch;`); err != nil {
return err
}
Expand Down
4 changes: 2 additions & 2 deletions pkg/cmd/roachtest/tests/tpcdsvec.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ func registerTPCDSVec(r registry.Registry) {
}
t.Status("restoring TPCDS dataset for Scale Factor 1")
if _, err := clusterConn.Exec(
`RESTORE DATABASE tpcds FROM 'gs://cockroach-fixtures/workload/tpcds/scalefactor=1/backup?AUTH=implicit';`,
`RESTORE DATABASE tpcds FROM 'gs://cockroach-fixtures-us-east1/workload/tpcds/scalefactor=1/backup?AUTH=implicit';`,
); err != nil {
t.Fatal(err)
}
Expand Down Expand Up @@ -188,7 +188,7 @@ func registerTPCDSVec(r registry.Registry) {
Cluster: r.MakeClusterSpec(3),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
if c.Spec().Cloud != spec.GCE {
t.Skip("uses gs://cockroach-fixtures; see https://github.com/cockroachdb/cockroach/issues/105968")
t.Skip("uses gs://cockroach-fixtures-us-east1; see https://github.com/cockroachdb/cockroach/issues/105968")
}
runTPCDSVec(ctx, t, c)
},
Expand Down
3 changes: 2 additions & 1 deletion pkg/roachprod/install/download.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ import (
)

const (
gcsCacheBaseURL = "https://storage.googleapis.com/cockroach-fixtures/tools/"
// We store downloadable content in a public bucket to allow for easy curling.
gcsCacheBaseURL = "https://storage.googleapis.com/cockroach-test-artifacts"
)

//go:embed scripts/download.sh
Expand Down
4 changes: 2 additions & 2 deletions pkg/roachprod/prometheus/prometheus.go
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ func Init(
fmt.Sprintf(`
(sudo systemctl stop node_exporter || true) &&
rm -rf node_exporter && mkdir -p node_exporter && curl -fsSL \
https://storage.googleapis.com/cockroach-fixtures/prometheus/node_exporter-1.2.2.linux-%s.tar.gz |
https://storage.googleapis.com/cockroach-test-artifacts/prometheus/node_exporter-1.2.2.linux-%s.tar.gz |
tar zxv --strip-components 1 -C node_exporter
`, binArch)); err != nil {
return nil, err
Expand Down Expand Up @@ -242,7 +242,7 @@ sudo systemd-run --unit node_exporter --same-dir ./node_exporter`,
cfg.PrometheusNode,
"download prometheus",
fmt.Sprintf(`sudo rm -rf /tmp/prometheus && mkdir /tmp/prometheus && cd /tmp/prometheus &&
curl -fsSL https://storage.googleapis.com/cockroach-fixtures/prometheus/prometheus-2.27.1.linux-%s.tar.gz | tar zxv --strip-components=1`,
curl -fsSL https://storage.googleapis.com/cockroach-test-artifacts/prometheus/prometheus-2.27.1.linux-%s.tar.gz | tar zxv --strip-components=1`,
binArch)); err != nil {
return nil, err
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/workload/querybench/2.1-sql-20
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
--
-- To load the data:
-- > CREATE DATABASE tpch;
-- > RESTORE workload.* FROM 'gs://cockroach-fixtures/workload/tpch/scalefactor=1/backup' WITH into_db = 'tpch';
-- > RESTORE workload.* FROM 'gs://cockroach-fixtures-us-east1/workload/tpch/scalefactor=1/backup' WITH into_db = 'tpch';
--
-- To run the queries using the querybench workload:
-- $ workload run querybench --concurrency 1 --max-ops 20 --db tpch --query-file 2.1-sql-20
Expand Down

0 comments on commit 7c7aabc

Please sign in to comment.