Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(platforms): change sentences in platforms whitepaper & add missing maturity-model contents in ko #646

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Eeap
Copy link
Contributor

@Eeap Eeap commented May 5, 2024

According to #641, I have translated it into Korean. Also I have changed wrong sentences(like missing img, words..) and added missing documents about maturity-model contents in kor platforms.

Thank you :)

Eeap added 2 commits May 5, 2024 12:08
Signed-off-by: Eeap <kdg97811@naver.com>
Copy link

netlify bot commented May 5, 2024

Deploy Preview for tag-app-delivery ready!

Name Link
🔨 Latest commit 74b899a
🔍 Latest deploy log https://app.netlify.com/sites/tag-app-delivery/deploys/663b52e2bc7cab00088b4113
😎 Deploy Preview https://deploy-preview-646--tag-app-delivery.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@abangser abangser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting to this so quickly @Eeap!

As with any other translation, we will just look for another fluent speaker to review/approve before merging.

In addition, I noticed that you have copied the english version of a page into website/content/ko/wgs/platforms/maturity-model/v1/index.md. I believe at this point we have this being done automatically if the page is not yet translated for the language. Is there something you noted that required this?

@Eeap
Copy link
Contributor Author

Eeap commented May 6, 2024

In addition, I noticed that you have copied the english version of a page into website/content/ko/wgs/platforms/maturity-model/v1/index.md. I believe at this point we have this being done automatically if the page is not yet translated for the language. Is there something you noted that required this?

Could I translate it with this PR until 8 May? Also, I know that another reviewer need for double checking..
I will find someone for checking as soon as possible :)

@Eeap
Copy link
Contributor Author

Eeap commented May 8, 2024

@abangser I have translated it into Korean, and I will find someone who can check this again :)

Hi, @sysnet4admin 😊
Could you check this one(https://github.com/cncf/tag-app-delivery/pull/646/files#diff-489ac0dd08634c836ce31340a71348904cf452dd8d893c543e6a63af52219f8c) if you have time for reading ??

@sysnet4admin
Copy link
Contributor

@Eeap Unfortunately, I have no time to contribute it anymore. you may consider with other member if you would like to review it.

@Eeap
Copy link
Contributor Author

Eeap commented May 8, 2024

Okay, I got it. Thank you :)

@Eeap
Copy link
Contributor Author

Eeap commented May 13, 2024

@abangser I have posted post for seeking people who would check it in linkedIn, but it takes some time for seeking 🥲.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants