Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize: support Chinese #64

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Localize: support Chinese #64

wants to merge 19 commits into from

Conversation

node
Copy link

@node node commented Nov 8, 2023

  • update config.toml to add new language config info for Chinese
  • add zh.toml under i18n
  • create content/zh and copy en pages
  • translate menu name and page title
  • translate all of the pages
    • home page _index.md
    • about
    • contribute
    • level 1
    • level 2
    • level 3
    • level 4
    • level 5

Copy link

netlify bot commented Nov 8, 2023

Deploy Preview for cncfmaturitymodel ready!

Name Link
🔨 Latest commit 0f8739a
🔍 Latest deploy log https://app.netlify.com/sites/cncfmaturitymodel/deploys/658ace16fc4c8f00082de025
😎 Deploy Preview https://deploy-preview-64--cncfmaturitymodel.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@node node marked this pull request as draft November 8, 2023 04:12
Signed-off-by: Chris (Gentle) Yang <nodexy@gmail.com>
Signed-off-by: Chris (Gentle) Yang <nodexy@gmail.com>
Signed-off-by: Chris (Gentle) Yang <nodexy@gmail.com>
Signed-off-by: Chris (Gentle) Yang <nodexy@gmail.com>
Signed-off-by: Chris (Gentle) Yang <nodexy@gmail.com>
Signed-off-by: Chris (Gentle) Yang <nodexy@gmail.com>
Signed-off-by: Chris (Gentle) Yang <nodexy@gmail.com>
Signed-off-by: Chris (Gentle) Yang <nodexy@gmail.com>
@node node marked this pull request as ready for review November 9, 2023 04:13
Signed-off-by: Chris (Gentle) Yang <nodexy@gmail.com>
Signed-off-by: Chris (Gentle) Yang <nodexy@gmail.com>
Signed-off-by: Chris (Gentle) Yang <nodexy@gmail.com>
Signed-off-by: Chris (Gentle) Yang <nodexy@gmail.com>
Signed-off-by: Chris (Gentle) Yang <nodexy@gmail.com>
Copy link

@kumarankit999 kumarankit999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you Mention the Issue related to this!
It Can help other folks to Understand more about this PR

@node
Copy link
Author

node commented Nov 19, 2023

Hi @kumarankit999 actually there is no issue about this PR but another PR #60 instead.

Signed-off-by: Chris (Gentle) Yang <nodexy@gmail.com>
@kumarankit999
Copy link

Its a good Practice if you create a PR related to any Issue

@node
Copy link
Author

node commented Nov 20, 2023

Thanks for your review, I just added a new issue to discuss this #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants