Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM West: Illyanna Ravenoak movement. #1191

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

evil-at-wow
Copy link
Contributor

In Dire Maul West, Illyanna Ravenoak is currently a static spawn, but she should be walking around with her bear Ferra at her side (more or less). This PR adds her waypoints, with data coming from version 3.0.8 build 9506, and puts her in a formation with her bear.

Note: Ferra should be switching sides at the end of the path, but this currently doesn't happen. As far as I could see, it was not possible to do this when I added this, but I've recently seen some core change related to mirroring...

Data coming from version 3.0.8 build 9506.
@al3xc1985
Copy link
Contributor

can u add the part with mirroring sides?

@evil-at-wow
Copy link
Contributor Author

My currently installed core doesn't support it so I can't test at the moment. But once I have updated my source tree again and have some time, I can check.

@Grz3s
Copy link
Member

Grz3s commented Mar 21, 2024

mirroring was added in wotlk.

@evil-at-wow
Copy link
Contributor Author

It might indeed well be that the feature hasn't made it to the TBC core yet, I simply haven't checked to be honest.

Either way, I can look into it once it's available in all cores, but until then I would say this is a step forward even though it's not perfect yet.

@Grz3s
Copy link
Member

Grz3s commented Mar 21, 2024

the feature hasn't made it to the TBC core yet

and shouldnt be added. As I said.. mirroring was added in wow 3.x.x ..(wotlk era) ..
Vanilla or TBC never had it... (or at least i never saw any)

Side note:
Wotlk was confirmed recently.. in Icecrown. (thats why was added)

@evil-at-wow
Copy link
Contributor Author

That's an interesting remark. As I noted in my commit here, the path data here is also from the 3.x era. So that's not proving anything related to TBC or vanilla.

So I did some more research in the meantime, and it turns out that Ferra was always on the same side, being left, of Illyanna in TBC Classic (so wow 2.5) rather than switching sides at the end of her path. I think it's very reasonable to conclude that the switching sides is only needed in wotlk-db then.

@al3xc1985
Copy link
Contributor

also, check her aggro range. I tested her on wotlk, even thou I was 80 she still aggroes from like 30y like nohing

@killerwife
Copy link
Collaborator

Mirroring is a db flag, so I think this is safe to merge @AnonXS i t hink.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants