Feedback neede: potentially wrong test -- 4 events found instead of expected 2

[maxaalexeeva]

There should be two events based on the test, but there are four in the output. Please, verify that the test asks for the right number of events. If there should indeed be 2 and not 4, please indicate which of the events in the output are correct and which need to be discarded.

The test:

reach/main/src/test/scala/org/clulab/reach/TestBindingEvents.scala

Line 77 in 9f4a04f

val sent5b = "Figure 3. Raf and PI3K bind more to ubiquitinated Ras than to non-ubiquitinated Ras."

The error message:

- should extract correct bindings with theme and theme2 *** FAILED *** (406 milliseconds)
[info]   List(org.clulab.reach.mentions.CorefEventMention@7a9947c0, org.clulab.reach.mentions.CorefEventMention@38b449b8, org.clulab.reach.mentions.CorefEventMention@61f51d14, org.clulab.reach.mentions.CorefEventMention@c2c3aeba) had size 4 instead of expected size 2 (TestBindingEvents.scala:90)

The (most relevant) webapp output:

EVENTS:   4

MENTION TEXT:  Raf and PI3K bind more to ubiquitinated Ras than to non-ubiquitinated Ras
LABELS:        List(Binding, SimpleEvent, Event, PossibleController)
DISPLAY LABEL: Binding
	------------------------------
	RULE => binding1b
	TYPE => BioEventMention
	------------------------------

	------------------------------
	TRIGGER => bind
	theme (List(Family, Equivalable, BioChemicalEntity, BioEntity, Entity, PossibleController)) => Raf
	theme (List(Family, Equivalable, BioChemicalEntity, BioEntity, Entity, PossibleController)) => Ras
	with 1 modification =>
		PTM (negated=false) = "Ubiquitination" based on "ubiquitinated"
CONTEXT: NONE
	------------------------------



MENTION TEXT:  Raf and PI3K bind more to ubiquitinated Ras
LABELS:        List(Binding, SimpleEvent, Event, PossibleController)
DISPLAY LABEL: Binding
	------------------------------
	RULE => binding1b
	TYPE => BioEventMention
	------------------------------

	------------------------------
	TRIGGER => bind
	theme (List(Family, Equivalable, BioChemicalEntity, BioEntity, Entity, PossibleController)) => Raf
	theme (List(Family, Equivalable, BioChemicalEntity, BioEntity, Entity, PossibleController)) => Ras
	with 1 modification =>
		PTM (negated=false) = "Ubiquitination" based on "ubiquitinated"
CONTEXT: NONE
	------------------------------



MENTION TEXT:  PI3K bind more to ubiquitinated Ras than to non-ubiquitinated Ras
LABELS:        List(Binding, SimpleEvent, Event, PossibleController)
DISPLAY LABEL: Binding
	------------------------------
	RULE => binding1b
	TYPE => BioEventMention
	------------------------------

	------------------------------
	TRIGGER => bind
	theme (List(Gene_or_gene_product, MacroMolecule, Equivalable, BioChemicalEntity, BioEntity, Entity, PossibleController)) => PI3K
	theme (List(Family, Equivalable, BioChemicalEntity, BioEntity, Entity, PossibleController)) => Ras
	with 1 modification =>
		PTM (negated=false) = "Ubiquitination" based on "ubiquitinated"
CONTEXT: NONE
	------------------------------



MENTION TEXT:  PI3K bind more to ubiquitinated Ras
LABELS:        List(Binding, SimpleEvent, Event, PossibleController)
DISPLAY LABEL: Binding
	------------------------------
	RULE => binding1b
	TYPE => BioEventMention
	------------------------------

	------------------------------
	TRIGGER => bind
	theme (List(Gene_or_gene_product, MacroMolecule, Equivalable, BioChemicalEntity, BioEntity, Entity, PossibleController)) => PI3K
	theme (List(Family, Equivalable, BioChemicalEntity, BioEntity, Entity, PossibleController)) => Ras
	with 1 modification =>
		PTM (negated=false) = "Ubiquitination" based on "ubiquitinated"
CONTEXT: NONE
	------------------------------

[maxaalexeeva]

@MihaiSurdeanu might be something for you to have a look at. One of the two curretnly ignored event tests.

[MihaiSurdeanu]

Actually, I think the correct number if 4!

@johnbachman: what do you think?