Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show some more examples #794

Draft
wants to merge 63 commits into
base: odin-debugger
Choose a base branch
from
Draft

Show some more examples #794

wants to merge 63 commits into from

Conversation

kwalcock
Copy link
Member

No description provided.

NickAvalani and others added 30 commits October 3, 2023 14:27
@NickAvalani
Added a timer for execution time but the implementation of partial ma…
ef57e46 
…tches data structure is buggy
@kwalcock
Make it compile
6b1e489
@navalani
Merge pull request #760 from clulab/kwalcock/compileThompson
deae650 
Make it compile
@NickAvalani
Fixed compilation errors for Partial Matches but copy() is still not …
dd4297d 
…recognized
@NickAvalani
Fixed compilation errors for Partial Matches but copy() is still not …
3504a0a 
…recognized
@NickAvalani
Solved merge conflicts
d1bfaf3
Remove unused imports
8044ae5
Move some of ThompsonVM to an Evaluator
0ac7b44
Start testing partial matches
9b97ebd
@NickAvalani
Testing ThompsonVM
84c0345
@NickAvalani
Changed the location of TestThompsonVM
0a1a788
@kwalcock
Trace what is happening with simple example rules and document
7634a67
Add design documents
af1a045
Rename eval method for clarity
1bfb1a2
Fix recursion in evaluator
2840460
Add another debugger level
b646023
Clean up formatting
9e8191f
Inspect code carefully
5f15bc8
Optimize diagram
4719c98
Clean ThompsonVM
59a529a
Update debugger documents
a216736
Remove extra visio files
b1c3067
Use OdinStarter as base for visualization
b04e47f
Break open GraphExtractor
f21222b
@NickAvalani
Visualization using graph nodes - buggy
beab9a1
@NickAvalani
Visualizing Extractor and Inst classes
f68743f
@NickAvalani
Visualizing the rule against the Inst tree
b3d244b
@NickAvalani
Visualizing the Inst subclasses other than Done
1bf0dc0
@kwalcock
Add visualize to the Inst trait
fa33a81
@kwalcock
Show some posIds
92f8c79
NickAvalani and others added 23 commits March 8, 2024 22:16
@NickAvalani
Fixed more merge conflicts
cb32ae3
@NickAvalani
Added visualization for WordConstraint
34cdd00
@NickAvalani
Added visualization for MatchToken
b070be4
@NickAvalani
Changed the visualization in OdinStarter
c7671b3
@kwalcock
Merge branch 'nick-avalani/odin-debugger' into kwalcock/traceOdinStarter
03218d3
@kwalcock
Touch up compilation
1ef1d5e
@navalani
Merge pull request #769 from clulab/kwalcock/traceOdinStarter
2572ab2 
Trace what is happening with simple example rules and document
@NickAvalani
Added visualization for done
ccb95ab
@NickAvalani
Merge branch 'nick-avalani/odin-debugger' of https://github.com/clula…
8d574c7 
…b/processors into nick-avalani/odin-debugger
@kwalcock
Checkpoint
0679051
@kwalcock
Checkpoint
8fc9272
@kwalcock
Checkpoint, still asserting
b30bef3
@kwalcock
Make it run to completion
915e122
@kwalcock
Track down Done
f76ae75
@kwalcock
Ask things of the debugger
ff97d39
@kwalcock
Show partial matches
b4a68f5
@kwalcock
Don't be quiet
59163f1
@kwalcock
Include four As example
6318977
@kwalcock
Show a match as well.
99ab820
@kwalcock
Uncomment rules
1082586
@kwalcock
Make earlier test case more interesting
ef48cdb
@kwalcock
Visualize where Insts match
6b178a9
@kwalcock
Copy test program from other branch
f8e454b
kwalcock
kwalcock commented Apr 19, 2024
View reviewed changes
main/src/main/scala/org/clulab/odin/debugger/Debugger.scala
type InstToDebuggerRecords = Map[Inst, Seq[DebuggerRecord]]

def visualize(extractor: Extractor, sentence: Sentence): Unit = {
val transcript = instance.transcript.toSeq.filter { debuggerRecord =>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly interesting changes here

kwalcock
kwalcock commented Apr 19, 2024
View reviewed changes
main/src/main/scala/org/clulab/odin/debugger/Debugger.scala
nextInst == null || (nextInst.getPosId <= inst.getPosId && nextInst.getPosId != 0)
}

val matchVisualization = debuggerRecords.map {debuggerRecord =>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly interesting changes here

@kwalcock
Copy link
Member Author

@NickAvalani , this partially overlaps with your matchTokens, but you might find it useful. Example output:

There was an extractor: food-followed-by-person
1. SaveStart(--GLOBAL--), which matches(0: pain, 3: John)
2. MatchToken(B-FOOD matches pain) -> 3, which matches(0: pain)
3. Split.  Check out my LHS and RHS!, which matches(1: au, 2: chocolat, 3: John)
   (LHS) 4. MatchToken(I-FOOD matches chocolat) -> 3, which matches(1: au, 2: chocolat)
   (RHS) 5. Pass, which matches(1: au, 2: chocolat, 3: John)
   (RHS) 6. MatchLookAhead.  Check out my start., which matches(3: John)
      (Start) 7. MatchToken(B-PER matches John) -> 0, which matches(3: John)
      (Start) 0. Done, which matches(4: <EOS>, 3: John)
   (RHS) 8. SaveEnd(--GLOBAL--), which matches(3: John)
   (RHS) 0. Done, which matches(4: <EOS>, 3: John)

@navalani
Copy link
Collaborator

Thanks @kwalcock, that helps alot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navalani navalani navalani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kwalcock @navalani @NickAvalani