Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for issues #6 and #7 #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

TomWeishaar
Copy link
Member

Please ensure the following before submitting a PR:

  • if suggesting code changes or improvements, open an issue first
    Issues 6 and 7.
  • for all but trivial changes (e.g., typo fixes), add your name to DESCRIPTION
  • for all but trivial changes (e.g., typo fixes), documentation your change in NEWS.md with a parenthetical reference to the issue number being addressed
  • if changing documentation, edit files in /R not /man and run devtools::document() to update documentation
  • add code or new test files to /tests for any new functionality or bug fix
  • make sure R CMD check runs without error before submitting the PR

The replyto issue, #6, is fixed in sendemail.R at lines 108-111.

The other changes in the two files have to do with issue 7. I fix this issue by allowing the user to enter key, secret, region, and force_credentials = TRUE in the send_email() function. The region in this case is the region of the AWS SES server, which, in the long run, is unlikely to be the region of the user's instance. I also added a bit to the Details about how to get the needed key and secret from AWS.

The fix also involves putting an if() statement around the locate_credentials call in http.R so that the user's credentials aren't over-written when force_credentials = TRUE and so that the region parameter in send_email() remains the SES region, not the instance region.

As an added side-effect, with these changes aws.ses allows a user with the proper credentials to send email from any computer, not just an instance on AWS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant