Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): provide an option to fix an issue where the target service cannot be found when a client using generic calls a multi-service server #1327

Conversation

Marina-Sakai
Copy link
Contributor

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@Marina-Sakai Marina-Sakai requested review from a team as code owners April 16, 2024 07:21
@Marina-Sakai Marina-Sakai changed the title fix: provide an option to fix an issue where the target service cannot be found when a client using generic/combine-service calls a multi-service server fix(client): provide an option to fix an issue where the target service cannot be found when a client using generic/combine-service calls a multi-service server Apr 16, 2024
@Marina-Sakai Marina-Sakai changed the title fix(client): provide an option to fix an issue where the target service cannot be found when a client using generic/combine-service calls a multi-service server fix(client): provide an option to fix an issue where the target service cannot be found when a client using generic calls a multi-service server Apr 23, 2024
@felix021
Copy link
Contributor

As suggested by Emma, it's better (easy to use and understand) to retrieve the Service Name from the generic call form:

gCli.Call(ctx, "$svc/$method", ...)

And since it's a derived option, even if it's not added to Kitex, users can achieve the goal without it.

Therefore I think currently we better not merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants