Prototype new auto-generation via the AWS resource specification file #1300
Conversation
First pass at improving troposphere python files using the AWS resource specification file. The base file for each service say, foo.py, will be auto-generated. There is an override file, foo.yaml, to include validation and other changes into the base file. The validation routines are now moved into foo_validators.py as either class mixins or property validation functions.
| LogDeliveryWrite = "LogDeliveryWrite" | ||
| classes: | ||
| CorsRules: | ||
| MaxAge: |
There was a problem hiding this comment.
Hmm - should these maybe be a sub key of something like Properties: or something like that, just to avoid collisions? I don't think i can think of any right now, so not really a strong opinion, just curious if you thought about it.
There was a problem hiding this comment.
That likely is a good change. One thing I might put in there is something to allow renaming the class which we've had to do on occasion. Also, you may have noticed there are breaking changes due to renamed resource/properties which could be mapped for backward compatibility via either a rename or alias.
There was a problem hiding this comment.
@phobologic also take a look at #1301.
There was a problem hiding this comment.
Ugh...should have thought about adding this to the above comment...sorry for the spam.
Look at both this and the other WIP with respect to the impact on stacker. Be good to understand those needs in case we change Python versions and/or how properties are used.
DO NOT MERGE THIS CHANGE - this is a WIP
As mentioned in #1295, I'm prototyping ways to better auto-generate troposphere files from the AWS resource specification. This should then allow for more rapid turnaround of new change from the CloudFormation team.
This PR is a quick first pass at improving troposphere python files using the AWS resource specification file. The base file for each service say, foo.py, will be auto-generated. There is an override file, foo.yaml, to include validation and other changes into the base file. The validation routines are now moved into foo_validators.py as either class mixins or property validation functions.
The main change is scripts/gen.py to improve the auto-generated files. The two files that are auto-generated are troposphere/batch.py and troposphere/s3.py with corresponding yaml and validator files. Note: some of the S3 changes are breaking changes due to class naming differences.
I'd like to get feedback on the general direction of this technique (note: I know the code needs cleanup and handle some edge cases). @phobologic @axelpavageau @cmmeyer