[plugin] use namespace to get the PodDisruptionBudgetList #4530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaveFun83
force-pushed
the
cnpg_pdb_status_fix
branch
from
63bfbf9
to
04be000
Compare
github-actions
bot
added
backport-requested ◀️
|
❗ By default, the pull request is configured to backport to all release branches.
|
|
i think b4c24da fixed it in a better way as the namespace is mandatory to get the cluster status. Now also non cluster-admin users are able to receive the correct pdb status. |
HaveFun83
changed the title
As these lines are added to 157 var pdbl policyv1.PodDisruptionBudgetList
158 if err := plugin.Client.List(ctx, &pdbl, client.MatchingLabels{utils.ClusterLabelName: clusterName}); err != nil {
159 return nil, fmt.Errorf("while extracting PodDisruptionBudgetList: %w", err)
160 }it can be backported to
|
leonardoce
force-pushed
the
cnpg_pdb_status_fix
branch
from
b4c24da
to
99a0398
Compare
|
Hi @HaveFun83, thank you for contributing to CNPG! |
|
sure i will try |
leonardoce
force-pushed
the
cnpg_pdb_status_fix
branch
2 times, most recently
from
948b21c
to
3b08dc8
Compare
|
Started an E2e test run on the EDB repo to save some OSS workers: https://github.com/EnterpriseDB/cloudnative-pg/actions/runs/9094968817 |
|
@leonardoce thanks a lot for your support |
|
E2e tests are green |
Signed-off-by: HaveFun83 <38665716+HaveFun83@users.noreply.github.com>
Signed-off-by: HaveFun83 <38665716+HaveFun83@users.noreply.github.com>
Signed-off-by: HaveFun83 <38665716+HaveFun83@users.noreply.github.com>
Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
leonardoce
force-pushed
the
cnpg_pdb_status_fix
branch
from
25d5774
to
f9bfc6b
Compare
leonardoce
approved these changes
May 15, 2024
|
Looks good to me. Waiting for another maintainer to review it. |
mnencia
approved these changes
May 15, 2024
|
/ok-to-merge e2e tests are green |
cnpg-bot
pushed a commit
that referenced
this pull request
May 15, 2024
In the kubectl plugin, when getting the list of PodDisruptionBudgets, the code wasn't restricting the selection to the namespace where the target Cluster resource has been created. This patch fixes that, with the added benefit of restricting the set of privileges needed by the user. Fixes #4522 Signed-off-by: HaveFun83 <38665716+HaveFun83@users.noreply.github.com> Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com> Co-authored-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com> (cherry picked from commit 7420aed)
cnpg-bot
pushed a commit
that referenced
this pull request
May 15, 2024
In the kubectl plugin, when getting the list of PodDisruptionBudgets, the code wasn't restricting the selection to the namespace where the target Cluster resource has been created. This patch fixes that, with the added benefit of restricting the set of privileges needed by the user. Fixes #4522 Signed-off-by: HaveFun83 <38665716+HaveFun83@users.noreply.github.com> Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com> Co-authored-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com> (cherry picked from commit 7420aed)
cnpg-bot
pushed a commit
that referenced
this pull request
May 15, 2024
In the kubectl plugin, when getting the list of PodDisruptionBudgets, the code wasn't restricting the selection to the namespace where the target Cluster resource has been created. This patch fixes that, with the added benefit of restricting the set of privileges needed by the user. Fixes #4522 Signed-off-by: HaveFun83 <38665716+HaveFun83@users.noreply.github.com> Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com> Co-authored-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com> (cherry picked from commit 7420aed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mitigate the behavior of
kubectl cnpg statuswhen the user don't have sufficient rights to list poddisruptionbudgets at the cluster scrope an error and the cnpg status output will be displayed.example output
Fixes #4522