fix: timeout when restarting PostgreSQL and while lifting fencing #4504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backport-requested ◀️
|
❗ By default, the pull request is configured to backport to all release branches.
|
leonardoce
force-pushed
the
dev/contexts-contexts
branch
from
658e0ad
to
5ac35a9
Compare
|
Hi! This one seems harmless and needed, but I encourage you to take a deep look. After much thinking, I still didn't make up my mind about whether it was better to fix it or leave it as it is and employ the energies on refactoring, to make the code flow clearer. |
armru
force-pushed
the
dev/contexts-contexts
branch
from
5ac35a9
to
e7819c4
Compare
armru
approved these changes
May 13, 2024
leonardoce
force-pushed
the
dev/contexts-contexts
branch
from
e7819c4
to
9ee4fa5
Compare
|
/test limit=local |
|
@leonardoce, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/9091027252 |
mnencia
force-pushed
the
dev/contexts-contexts
branch
from
9ee4fa5
to
c89fbe7
Compare
|
/test tl=4 l=local |
|
@mnencia, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/9131874590 |
The instance manager starts PostgreSQL: 1. when it starts up 2. when configuration changes are being applied (after stopping it) 3. when fencing is lifted. In the second and third example, the operator is requested by the embedded cluster reconciler loop, and performed without any timeout. If PostgreSQL won't start up again because of a wrong configuration or missing disk space, the reconciler loop will be stuck waiting for a dead postmaster to be up. This patch handles this condition by using a combination of the timeout parameters that are already set in the cluster. Fixes: cloudnative-pg#4501 Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enteprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
mnencia
force-pushed
the
dev/contexts-contexts
branch
from
c89fbe7
to
0ad2f7f
Compare
|
/ok-to-merge E2E green. Only expected unrelated failures. |
mnencia
approved these changes
May 20, 2024
cnpg-bot
pushed a commit
that referenced
this pull request
May 20, 2024
) The instance manager starts PostgreSQL: 1. when it starts up 2. when configuration changes are being applied (after stopping it) 3. when fencing is lifted. In the second and third examples, the operator is requested by the embedded cluster reconciler loop, and performed without any timeout. If PostgreSQL won't start up again because of a wrong configuration or missing disk space, the reconciler loop will be stuck waiting for a dead postmaster to be up. This patch handles this condition by using a combination of the timeout parameters that are already set in the cluster. Fixes: #4501 Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enteprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Leonardo Cecchi <leonardo.cecchi@enteprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit 09a4d80)
mnencia
pushed a commit
that referenced
this pull request
May 20, 2024
) The instance manager starts PostgreSQL: 1. when it starts up 2. when configuration changes are being applied (after stopping it) 3. when fencing is lifted. In the second and third examples, the operator is requested by the embedded cluster reconciler loop, and performed without any timeout. If PostgreSQL won't start up again because of a wrong configuration or missing disk space, the reconciler loop will be stuck waiting for a dead postmaster to be up. This patch handles this condition by using a combination of the timeout parameters that are already set in the cluster. Fixes: #4501 Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enteprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Leonardo Cecchi <leonardo.cecchi@enteprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit 09a4d80)
mnencia
pushed a commit
that referenced
this pull request
May 20, 2024
) The instance manager starts PostgreSQL: 1. when it starts up 2. when configuration changes are being applied (after stopping it) 3. when fencing is lifted. In the second and third examples, the operator is requested by the embedded cluster reconciler loop, and performed without any timeout. If PostgreSQL won't start up again because of a wrong configuration or missing disk space, the reconciler loop will be stuck waiting for a dead postmaster to be up. This patch handles this condition by using a combination of the timeout parameters that are already set in the cluster. Fixes: #4501 Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enteprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Leonardo Cecchi <leonardo.cecchi@enteprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit 09a4d80)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The instance manager starts PostgreSQL:
In the second and third examples, the operator is requested by the embedded cluster reconciler loop, and performed without any timeout.
If PostgreSQL won't start up again because of a wrong configuration or missing disk space, the reconciler loop will be stuck waiting for a dead postmaster to be up.
This patch handles this condition by using a combination of the timeout parameters that are already set in the cluster.
Fixes: #4501