chore: improve the operator deployment detection #4427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxd
requested review from
fcanovai,
gbartolini,
leonardoce,
mnencia,
phisco and
armru
as code owners
github-actions
bot
added
backport-requested ◀️
|
❗ By default, the pull request is configured to backport to all release branches.
|
sxd
force-pushed
the
dev/4426
branch
2 times, most recently
from
b3aa47d
to
0571a48
Compare
|
/test feature_type=operator test_level=4 |
|
@jsilvela, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/8985522953 |
|
/test feature_type=operator test_level=4 |
|
@jsilvela, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/8987412660 |
|
@jsilvela, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/8987414033 |
jsilvela
approved these changes
May 7, 2024
litaocdl
approved these changes
May 9, 2024
leonardoce
approved these changes
May 15, 2024
|
/test feature_type=operator test_level=4 limit=local depoth=schedule |
|
@sxd, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/9098443345 |
|
/test feature_type=operator test_level=4 limit=local depoth=schedule |
|
@sxd, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/9098860101 |
Using the Deployment object from the Kubernetes environment we can get all the information for the deployment more accurated than just listing and couting pods, which it's an issue when you have another pod in the same namespace. Closes #4426 Signed-off-by: Jonathan Gonzalez V. <jonathan.gonzalez@enterprisedb.com> Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
cnpg-bot
pushed a commit
that referenced
this pull request
May 15, 2024
This patch makes the E2e tests get the number of operator Pods by looking into the Deployment resource instead of counting the listed Pods. The E2e tests will now work when more than one operator is deployed in the same namespace, i.e. when operators are deployed with OLM. Closes #4426 Signed-off-by: Jonathan Gonzalez V. <jonathan.gonzalez@enterprisedb.com> Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com> (cherry picked from commit 32528f4)
cnpg-bot
pushed a commit
that referenced
this pull request
May 15, 2024
This patch makes the E2e tests get the number of operator Pods by looking into the Deployment resource instead of counting the listed Pods. The E2e tests will now work when more than one operator is deployed in the same namespace, i.e. when operators are deployed with OLM. Closes #4426 Signed-off-by: Jonathan Gonzalez V. <jonathan.gonzalez@enterprisedb.com> Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com> (cherry picked from commit 32528f4)
cnpg-bot
pushed a commit
that referenced
this pull request
May 15, 2024
This patch makes the E2e tests get the number of operator Pods by looking into the Deployment resource instead of counting the listed Pods. The E2e tests will now work when more than one operator is deployed in the same namespace, i.e. when operators are deployed with OLM. Closes #4426 Signed-off-by: Jonathan Gonzalez V. <jonathan.gonzalez@enterprisedb.com> Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com> (cherry picked from commit 32528f4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the Deployment object from the Kubernetes environment we can get all the information for the deployment more accurate than just listing and counting pods, which it's an issue when you have another pod in the same namespace.
Closes #4426