feat: enhance shutdown process for demotion of the cluster #4411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backport-requested ◀️
|
❗ By default, the pull request is configured to backport to all release branches.
|
|
/test limit=local |
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/8907157613 |
armru
requested review from
fcanovai,
gbartolini,
leonardoce,
mnencia,
phisco and
sxd
as code owners
|
/test limit=local |
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/8970292966 |
|
/test limit=local |
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/8981364872 |
|
/test limit=local |
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/8981390629 |
armru
removed
backport-requested ◀️
armru
force-pushed
the
dev/3790
branch
4 times, most recently
from
e66b119
to
657be55
Compare
Closes #3790 Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
gbartolini
reviewed
May 30, 2024
Comment on lines
+927
to
+932
| // ShutdownCheckpointToken is a json token containing the following information from pg_controldata: | ||
| // Database system identifier | ||
| // Latest checkpoint's TimeLineID | ||
| // Latest checkpoint's REDO location | ||
| // Latest checkpoint's REDO WAL file | ||
| // Time of latest checkpoint |
There was a problem hiding this comment.
Suggested change
| // ShutdownCheckpointToken is a json token containing the following information from pg_controldata: | |
| // Database system identifier | |
| // Latest checkpoint's TimeLineID | |
| // Latest checkpoint's REDO location | |
| // Latest checkpoint's REDO WAL file | |
| // Time of latest checkpoint | |
| // shutdownCheckpointToken is a JSON token containing the information | |
| // from pg_controldata such as Database system identifier, Latest checkpoint's | |
| // TimeLineID, Latest checkpoint's REDO location, Latest checkpoint's REDO | |
| // WAL file, and Time of latest checkpoint |
gbartolini
changed the title
ShutdownCheckpointTokenCluster shutdown process for demotion
gbartolini
changed the title
Cluster shutdown process for demotion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch enhances the shutdown process for demoting a primary cluster in CloudNativePG by:
shutdownCheckpointTokenin theClusterstatus, containing information in JSON format retrieved frompg_controldata. This includes the database system identifier, latest checkpoint'sTimeLineID, latest checkpoint's REDO location, latest checkpoint's REDO WAL file, and the time of the latest checkpoint..partialfile. This facilitates the controlled promotion of a replica cluster by relying solely on the WAL archive.Note that this implementation does not cover the hibernation case, which will be addressed in a separate patch.
Closes #3790
Closes #4586