TCP quick ack #679
Draft
TCP quick ack #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that client's don't need to disable nagle's algorithm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
Enable TCP quick ack after each frame that doesn't generates a reply, so that client's don't need to disable nagle's algorithm, in write-write-read scenarios.
HOW can this pull request be tested?
Send two frames, then wait for a response, eg Basic.consume with no_wait and then publish a message to that queue. Without TCP quick ack, or TCP no delay on the client side, the client will wait 40ms for the server to TCP ack the last basic.consume frame before sending the publish frames.
With TCP no delay on the client side the client don't wait for TCP acks from the server to send the next TCP packet, but it also means that it won't aggregate many small publishes in large TCP packets.
This PR currently has a performance hit for publish only workloads.