Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging refactor #543

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Logging refactor #543

wants to merge 3 commits into from

Conversation

carlhoerberg
Copy link
Member

Use Log rather than @log when possible

@carlhoerberg carlhoerberg marked this pull request as draft July 6, 2023 23:01
@github-actions
Copy link

github-actions bot commented Jul 6, 2023 •
edited

Main benchmark
'Average publish rate: 329142.9 msgs/s'
'Average consume rate: 330836.6 msgs/s'

PR benchmark
'Average publish rate: 329954.1 msgs/s'
'Average consume rate: 327717.2 msgs/s'

Keep in mind, these numbers are not representative of LavinMQ's peak performance.
It is rather an indication of how the changes of this pull request affects the performance of the main branch.

@carlhoerberg carlhoerberg force-pushed the logging-refactor branch 2 times, most recently from 3d340db to 793d3f7 Compare July 20, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kickster97 kickster97 Awaiting requested review from kickster97 kickster97 will be requested when the pull request is marked ready for review kickster97 is a code owner

@snichme snichme Awaiting requested review from snichme snichme will be requested when the pull request is marked ready for review snichme is a code owner

@spuun spuun Awaiting requested review from spuun spuun will be requested when the pull request is marked ready for review spuun is a code owner

@viktorerlingsson viktorerlingsson Awaiting requested review from viktorerlingsson viktorerlingsson will be requested when the pull request is marked ready for review viktorerlingsson is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@carlhoerberg