Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix return type in AMQPConsumer constructor #93

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix return type in AMQPConsumer constructor #93

wants to merge 1 commit into from

Conversation

JoshJarabek7
Copy link

Originally only had void as the return type, and the example on the README.md showed a Promise being returned, causing yellow squiggles from Typescript / Sonarlint.

@JoshJarabek7
Fix return type in AMQPConsumer constructor
8c87666 
Originally only had void as the return type, and the example on the README.md showed a Promise<void> being returned, causing yellow squiggles from Typescript / Sonarlint.
@baelter
Copy link
Member

baelter commented Sep 28, 2023 •
edited

Isn't that because your onMessage callback returns a Promise. In that case I guess we should change to any in the lib since we can't control what users of the lib return in their callbacks. Or the lib should handle async callbacks.. WDYT @carlhoerberg?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JoshJarabek7 @baelter