Use thiserror for better error handling #6434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When you fix the build issue please make sure you squash them into the appropriate commits e.g. you can use |
|
Please setup the git hooks as described in the CONTRIBUTING.md file. |
|
For some reason the hook didn't catch that error, had to run the same command as in the test to check. It's fixed now. |
rbradford
reviewed
May 3, 2024
rbradford
reviewed
May 3, 2024
api_client/src/lib.rs
Outdated
| Socket(std::io::Error), | ||
| #[error("Error writing to or reading from HTTP socket: {0}")] |
There was a problem hiding this comment.
I know you copied from the Display implementation but this error is about sending file descriptors. Please fix as a separate commit.
|
I think this is lgtm - @likebreath ? |
SamrutGadde
force-pushed
the
use-thiserror
branch
2 times, most recently
from
d092606
to
52b66de
Compare
|
apologies, added an accidental commit. |
likebreath
reviewed
May 6, 2024
Added thiserror crate for Error enums to the api_client package Signed-off-by: SamrutGadde <samrut.gadde@gmail.com>
Added thiserror crate for missing files in the arch package Signed-off-by: SamrutGadde <samrut.gadde@gmail.com>
Added thiserror for missing files in the qcow module. Signed-off-by: SamrutGadde <samrut.gadde@gmail.com>
Updated error enums in device package to use thiserror crate Signed-off-by: SamrutGadde <samrut.gadde@gmail.com>
Updated error enums in hypervisor under aarch64 to use thiserror crate Signed-off-by: SamrutGadde <samrut.gadde@gmail.com>
Updated error message for the SocketSendFds error to be more descriptive. Signed-off-by: SamrutGadde <samrut.gadde@gmail.com>
SamrutGadde
force-pushed
the
use-thiserror
branch
from
52b66de
to
fab6c32
Compare
likebreath
approved these changes
May 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the delay, but I've made the suggested changes as mentioned in a previous pull request (See #6376).
I've added just a few of the commits here to make it easier for review, let me know if you see any changes need to be made.
See #1910