Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade acme version to avoid x509 deprecation #287

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

markdboyd
Copy link
Contributor

Changes proposed in this pull request:

We need to stay on acme < 2.8 for now because acme 2.8.0 uses pyopenssl 23.3.0 which deprecates x509, but the acme package hasn't been updated to handle that deprecation.

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

There are no apparent security issues with acme < 2.8.0 at the moment. And will upgrade acme as soon as the upstream issue with the pyopenssl dependency is resolved.

@markdboyd markdboyd requested a review from a team February 7, 2024 16:32
@markdboyd markdboyd merged commit a70794f into main Feb 7, 2024
1 check passed
@markdboyd markdboyd deleted the downgrade-acme-version branch February 7, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants