call_reducer_with_tx: move work before/after tx lock aquire/release
#1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
added
enhancement
Shubham8287
reviewed
Apr 16, 2024
kim
reviewed
Apr 16, 2024
Centril
force-pushed
the
centril/reducer-hold-tx-less
branch
from
a82e483
to
10eb9d6
Compare
bfops
added
release-any
1. Create ctx & clone tx_slot before taking tx lock. 2. Move an allocation before taking tx lock. 3. Move energy_monitor.record_reducer(..) to after releasing tx lock. 4. Move tracing & metrics work to after releasing tx lock.
Centril
force-pushed
the
centril/reducer-hold-tx-less
branch
from
84663d0
to
9f57c85
Compare
…ptions so we do not include energy, reducer span stuff, and long running reducer work in the duration.
Centril
force-pushed
the
centril/reducer-hold-tx-less
branch
from
9f57c85
to
c4f6d61
Compare
coolreader18
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Most of these were noticeable in the 380 CCU flame graph.
ctx& clonetx_slotbefore takingtxlock.txlock.energy_monitor.record_reducer(..)to after releasingtxlock.txlock.Arc<ModuleEvent>(last referent) to outside ofblocking_broadcast_event, reducing the time thesubscriptions.read()lock andtxlock is held.record_metricsafter tx/subscription locks have been released.merge_apply_insertsandmerge_apply_deletesto update metrics at most once per table.API and ABI breaking changes
None
Expected complexity level and risk
3 - We've had deadlocks and threading issues in this code path before, so review the logic with care.
Testing
A playtest would be good to run before merging, primarily for safety reasons.