Fix output of binary, Identity, Address for SQL output and the 'Display' of them to show a full hex value
#1087
+205
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamcx
added
release-any
mamcx
commented
Apr 12, 2024
| @@ -38,7 +38,7 @@ impl Default for Address { | |||
|
|
|||
| impl fmt::Display for Address { | |||
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | |||
| f.pad(&self.to_hex()) | |||
| write!(f, "0x{}", self.to_hex()) | |||
There was a problem hiding this comment.
This makes this a breaking change. Should I remove this?
mamcx
commented
Apr 12, 2024
| @@ -99,7 +99,7 @@ impl Identity { | |||
|
|
|||
| impl fmt::Display for Identity { | |||
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | |||
| f.pad(&self.to_hex()) | |||
| write!(f, "0x{}", self.to_hex()) | |||
There was a problem hiding this comment.
This makes this a breaking change. Should I remove this?
…them to show a full hex string
cloutiertyler
added
release-0.10
release-1.0
and removed
release-any
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion for Implement 'SQL' parsing for 'Identity, Address' in hex format, so now we have a correct round-trip of binary values in
SQL.Now when printing an
SQLoutput that hasBinary,Identity, orAddressfields it correctly displays them as ahexvalue.Description of Changes
Please describe your change, mention any related tickets, and so on here.
API and ABI breaking changes
I also change the
DisplayofIdentity&Addressthat mar this as potentially breaking.Before they print like
00000000000000000000000000000000but now0x00000000000000000000000000000000.If desired then I could revert that part. Because the print of `SQL' is changed for these types is also a breaking change anyway (if only for the small chance somebody depend in the old way of display them).
Expected complexity level and risk
2
Is there any implication in change the
DisplayofIdentity&Address?Testing
SQLSQLoutput using thecli.