Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitauth] Bumping to version 0.3.1 #255

Closed
wants to merge 0 commits into from
Closed

Conversation

xcthulhu
Copy link
Contributor

BitAuth now had unicode support!

With this revision I will be updating my wrapper accordingly.

@xcthulhu xcthulhu changed the title Bumping to version 0.3.1 [bitauth] Bumping to version 0.3.1 Oct 10, 2015
@xcthulhu
Copy link
Contributor Author

xcthulhu commented Nov 7, 2015

Okay, I have been working on this, it appears that BitAuth 0.3.1 broke Closure support by switching how it was using browserify.

This was breaking CLJSJS and my own ClojureScript wrapper further downstream. I believe that my latest commit bitpay/bitauth#56 restores CLJSJS and my wrapper, but it's not 100% clear. The javascript code being wrapped is output by browserify which is complicated and unpredictable.

I will wait for BitPay to pull my commit in, and make another pull request when I can confirm using ClojureScript testing that the latest version of bitauth is functioning properly with clojurescript.

@xcthulhu
Copy link
Contributor Author

xcthulhu commented Nov 8, 2015

I can confirm that this version has been tested with my UTF-8 branch of my clj-bitauth project and this is 100% compatible with my JVM implementation.

Here is my branch that I am referring to: https://github.com/xcthulhu/clj-bitauth/tree/utf-8

@Deraen
Copy link
Member

Deraen commented Nov 19, 2015

I won't accept PR which adds the source code to the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants