Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing tests, cleanup issues w/running tests locally #301

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix failing tests, cleanup issues w/running tests locally #301

wants to merge 1 commit into from

Conversation

exbotanical
Copy link
Contributor

This PR fixes some of the issues in this ci failure and false negatives when running tests locally (e.g. due to inadvertently running the cache tests twice).

Changes:

  • Use traps to cleanup test artifacts (in case a test fails, we don't leave the artifacts to potentially cause false negatives in the next test).
  • Allow ctrl+c to fast-exit from test script
  • Ensure all binary installs in tests set the prefix opt (avoids perms issues in some systems)
  • Fix test script such that cache tests only run once

Thanks

@jwerle @stephenmathieson

@exbotanical
fix: Create missing tmp dirs for test artifacts and cleanup before/after
45b4e7a 
fix: Only run cache tests once

This fix ensures the test script only runs the cache tests once, as
intended. Prior, the cache test binary would get picked up by the `find`
in test.sh and execute.

Because we don't explicitly run `make clean` here, subsequent test runs
always fail.
`# Please enter the commit message for your changes. Lines starting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwerle jwerle jwerle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@exbotanical @jwerle