Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make loss function a parameter in torch implementation #1222

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gkysaad
Copy link

@gkysaad gkysaad commented Nov 17, 2021

Implemented fix to this issue: #1211.
The loss_fn used must only take 2 parameters (output and target).

@kylematoba
Copy link

This seems great. It'd help me if you could also make the same change in this call: https://github.com/cleverhans-lab/cleverhans/blob/master/cleverhans/torch/attacks/projected_gradient_descent.py#L123.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants