Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clerk-js,types): Default to terms, privacy and help URLs set in the dashboard #3195

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

desiprisg
Copy link
Member

@desiprisg desiprisg commented Apr 15, 2024

Description

We now get three new fields in the /v1/environment response. Inside display_config , we will find

  • terms_url
  • privacy_policy_url
  • help_url

These will be the defaults for our footer links. Props from appearance.layout are still prioritized.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Apr 15, 2024

🦋 Changeset detected

Latest commit: 68bfecc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@clerk/clerk-js Minor
@clerk/types Minor
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/backend Patch
@clerk/express Patch
@clerk/fastify Patch
gatsby-plugin-clerk Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
@clerk/themes Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@desiprisg desiprisg force-pushed the george/sdk-1631-clerk-js-terms-privacy-and-help-page-urls-implementation branch 2 times, most recently from 4a9a257 to 943cc1e Compare April 15, 2024 21:04
@desiprisg desiprisg self-assigned this Apr 15, 2024
@desiprisg desiprisg marked this pull request as ready for review April 15, 2024 21:06
@desiprisg desiprisg changed the title feat(clerk-js,types): Priotize terms, privacy and help URLs set in the dashboard feat(clerk-js,types): Default to terms, privacy and help URLs set in the dashboard Apr 15, 2024
@desiprisg desiprisg force-pushed the george/sdk-1631-clerk-js-terms-privacy-and-help-page-urls-implementation branch from 943cc1e to 68bfecc Compare April 15, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants