Added shouldDismissPresentedViewController property to options #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -71,12 +71,14 @@ typedef void (^RouterOpenCallback)(NSDictionary *params); | |||
| @param defaultParams The default parameters which are passed when opening the URL | |||
| @param isRoot The boolean `shouldOpenAsRootViewController` property is set to | |||
| @param isModal The boolean that sets a modal presentation format | |||
| @param shouldDismissPresentedViewController The boolean inidicating wheter an already existing presentedViewController should be dismissed before presenting a new one | |||
|
I think this would be useful! if we keep backwards compatibility. I am wary of adding a bunch of options, but I think it's okay for now can we add a test for this? |
|
@clayallsopp thanks for taking a look so fast, I just fixed the typos, added the method back in for backwards compatibility and fixed the indentation. Please also see my other comment. |
|
awesome! can you add tests? the existing ones should point you in the right direction |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently had the need to stack multiple modal navigation controller in my app. Therefore I added a shouldDismissPresentedViewController property to the options to enable this functionality in my app.
Maybe someone else finds that functionality useful :)