Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rects measuring on elements change #1094

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

akantic
Copy link

@akantic akantic commented Apr 3, 2023

A fix for #1092, I am not sure if there are any other implications with this change so any input is appreciated.

What was happening?

When using multiple containers scrollableAncestors would get updated, but their rects would not.
So, let's imagine dragging from one container to another, first we have something like:

scrollableAncestors = [parent, grandparent]
scrollableAncestorsRects = [parentRect, grandparentRect]

Then ancestors get updated to just one element in between switching containers, but rects do not.

scrollableAncestors = [grandparent]
scrollableAncestorsRects = [parentRect, grandparentRect]

Then, this code brings chaos:

const index = scrollableAncestors.indexOf(scrollContainer);
const scrollContainerRect = scrollableAncestorRects[index];

Because for grandparent scrollContainer it would use index 0 to access rects, leading to scrollContainerRect being parentRect for grandparent container - causing seemingly random jumps as can be seen in the video from the issue referenced on top.

@changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2023

⚠️ No Changeset found

Latest commit: 3c20737

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant