Improved closed_captions compatibility with hlsjs-playback. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed sync issues between closed_captions GUI and actual backend state when using hlsjs-playback. * closed_captions menu now renders track names with suffix ' (forced)' if indicated by an optional boolean field `tracks[i].attributes.forced` (currently only provided by hlsjs-playback via a pull request I made earlier ).
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracks[i].attributes.forced(currently only provided by hlsjs-playback via a pull request I made earlier ).This PR is meant to go along with my other PR in the hlsjs-playback repo but can also provide some small benefit when used standalone.