Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autobatching bug fixed. #1666

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

autobatching bug fixed. #1666

wants to merge 1 commit into from

Conversation

cydur
Copy link
Contributor

@cydur cydur commented Oct 24, 2023

This bugfix addresses the problem I already found several years ago. See my comment to Issue #1582.
I don't think it really was the same problem as the original error described in this issue because my problem was in the backward step and now I think #1582 could have been a problem in the forward step.

In any case this change fixes my problem. And the problem was (autobatching = 1):

  • A auto-batched "+" node was the first argument of an also auto-batched "*" node.
    In this case the backward step in exec.cc called node->backward() with the batch tensor as last argument instead of the correct sub-tensor of this batch.

@cydur
Copy link
Contributor Author

cydur commented Oct 24, 2023

Well, I don't think my change has anything to do with the continuous integration error
"ERROR conda.core.link:_execute(502): An error occurred while installing package 'defaults::charset-normalizer-2.0.4-pyhd3eb1b0_0'.
CondaError: Cannot link a source that does not exist. C:\Miniconda36-x64\Scripts\conda.exe"

Seems to be a problem in the build environment...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant