Swig multi device #1574
Open
Swig multi device #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Cover more exceptions with %catches feature. * Use more recent versions of Scala and dependencies. * Some modification to get rid of deprecation warnings.
* Compiles and all tests pass, hopefully not broken
* improved Device * update Expression.concatenate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for multi device with SWIG bindings.
It builds and all tests are passing on macOS CPU and Linux CPU/GPU.
A toy program I translated from train_xor-multidevice.cc to scala runs as expected, and my fairly complicated program which I wrote before multi-device support is functioning with these changes as well.
So I assume it doesn't break existing Scala codes at least.