Implement pseudoinstructions in Rotor disassembly #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean-M22
changed the title
This looks so much uglier without &&, can we add && to rotor? 😆
Jean-M22
commented
May 30, 2024
ckirsch
requested changes
May 30, 2024
There was a problem hiding this comment.
@Jean-M22 looks really nice!
Please change the following (all easy to do):
- avoid changes to .gitignore
- change the type of rd, rs1, and rs2 to uint64_t, also in print_assembly, and then use get_register_name only in the last moment when printing
- add a flag for turning off printing of pseudo instructions, default should be on
Thanks a lot!
Jean-M22
force-pushed
the
objdump-analyzer
branch
from
325644c
to
10a0136
Compare
|
I have implemented the requested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for printing pseudoinstructions in rotor disassembly.
Pseudoinstructions are implemented (mostly) according to the RISC-V spec, with a few exceptions noted by comments.
The aim of this pull request was to get Rotor to disassemble instructions as closely as possible to RISC-V objdump