Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameter resolving issues with procedure calls when auto_explain is enabled. #7598

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

emelsimsek
Copy link
Contributor

@emelsimsek emelsimsek commented May 13, 2024

There are two ways to generate explain resullts:

  1. Run the EXPLAIN command with query
  2. Turn on auto_explain, to quitely explain queries in the logs.

Citus follows different code paths in those two cases.

It runs out that auto_explain code path cannot handle parameters to procedures when explaining the procedure calls.

I am not highly confident in this change, expecially the part where I had to skip parameters with type 0, to make the code work, but the solution should be similar to this.

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.70%. Comparing base (553d5ba) to head (2b520fd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7598   +/-   ##
=======================================
  Coverage   89.69%   89.70%           
=======================================
  Files         283      283           
  Lines       60506    60510    +4     
  Branches     7538     7539    +1     
=======================================
+ Hits        54270    54279    +9     
+ Misses       4081     4077    -4     
+ Partials     2155     2154    -1     

@emelsimsek emelsimsek changed the title Attempt to fix parameter passing with auto_explain Fix parameter resolving issues with procedure calls when auto_explain is enabled. May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant