Adds support for granted by propagation for grant statements without filtering non-distributed roles #7558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds a sync filter for metadata sync
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7558 +/- ##
==========================================
- Coverage 89.69% 89.63% -0.07%
==========================================
Files 282 282
Lines 60462 60525 +63
Branches 7530 7539 +9
==========================================
+ Hits 54233 54251 +18
- Misses 4078 4118 +40
- Partials 2151 2156 +5 |
gurkanindibay
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #7538.
In this PR, non-distributed roles are not being filtered when executing grant statements and sending grant statements in metadata sync.
According to the requirements that @JelteF expressed, most of the time non distributed roles exists in all nodes but they are not marked as distributed in pg_dist_object.
Either this PR or #7538 should be accepted. Please evaluate both PR's together and be aware that just one of them will be merged